| [egit-dev] Learning the right way to push changes |
| I discovered a bug with the earlier change I'd pushed to the review (and which Mathias kindly committed for me into 2854822da4c717e8df745486b440000639f80d49). Specifically, I'd forgotten to: * Dispose of the clipboard * Handle the case where there is no text (say, because the buffer is empty or because it contains an image) I also wanted to add: * Trim the text so that it works if you have leading/trailing spaces This seems to have resulted in a number of review requests. Ideally, I'd like to do a git commit squash on these three items, and (if no-one has pushed anything on top of the 2854822) squash that as well. But I'm more than happy to leave 2854822 there, and squash the three changes into the 345..1b8 into one commit and push that as a review. So that I know for next time, what should I have done? Done the commit squash first, and just pushed one thing into the review? If I need to do tweaks in the future, how do I ensure that they are treated as different patch sets on the same review rather than creating new ones? Alex 3457f5e Trim correctly 2c637ce Don't fall over if the clipboard text is not null, and trim it 1b8eeae Remember to dispose the clipboard after use 2854822 Allow Git repository to be pre-filled from clipboard <- git/master at the moment |