Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] Cleanup of menu actions "Track", "Update", "Refresh" ?

2010/6/1 Chris Aniszczyk <caniszczyk@xxxxxxxxx>
On Tue, Jun 1, 2010 at 10:08 AM, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote:
> I agree, its crazy.

+1! I would toss everything but Refresh once we're ready unless
someone can give a good reason why Refresh should be tossed...
 
I would prefer to stick to "Add" for the sake of consistency with native git. Using a "Refresh" action
to put a new file under version control or to stage it in the index sounds odd to me.
 
It's probably best to open a bug on this issue and track it for
0.9.0... where we will do more cleanup. I plan on modifying the team
menu contributions to use the new command/menu story since we will be
running on Eclipse 3.5+ as of 0.9.0+

created bug 315306 for that
 
> I think the reason we can't just have "Add" yet is we need to get
> that ignore support finished.  I know we have a code review pending
> for at least some of that in JGit, I unfortunately have lacked the
> time [1] to read it.  :-(

It's my hope we have proper .gitignore support in 0.9.0
    http://egit.eclipse.org/r/#change,683

yes, when helios is out we should invest a bit more time in reviewing this change and 
helping Charley to get his change ready.
 
--

Matthias

Back to the top