Re: [egit-dev] Missing CQ's

[Robin Rosenberg <robin.rosenberg@xxxxxxxxxx>]

lördagen den 3 april 2010 21.01.50 skrev  Shawn O. Pearce:
> Robin Rosenberg <robin.rosenberg@xxxxxxxxxx> wrote:
> > A number of large commits have entered EGit without CQ's. Seems to be SAP
> > so maybe Mathias Sohn can handle that.
> 
> This has been going on per figure 2 of the Eclipse Legal Process
> Due Diligence Poster.  Since its same company, the company is a
> foundation member company, it has no cryptograph, is new code,
> and is EPL, its permitted without a CQ.  Notice there is no line
> count requirement here.

Ok, I follow that, hence no IP problem. Thanks for clearing that up.

> > Making Mathias Kinzler a comitter would
> > solve that for future contributions.
> 
> We can do this.  It just requires an existing committer to nominate
> him in the portal, and highlight the contributions made thus far,
> so the rest of us can vote.
>
> I'd love to bring more committers in.  But I clearly don't pay
> very much attention to EGit itself.  So I can't say I've paid any
> attention at all to what Mathias Kinzler has contributed thus far, so
> I'm really not the right person to nominate him as a new committer.

First the code should work in Eclipse 3.4 ;-)

> :-(
> :
> > That obviously leads us to believe that Gerrit could warn us about these
> > things or at least do a line count, and the IP tool could perhaps verify
> > that a reference to a CQ exists when one is needed.
> 
> All easily done.  Gerrit can compute line numbers.  And the IP tool
> can try to whine if a given change is >250 and doesn't have a CQ
> with it.
> 
> The IP log tool we use is part of JGit.  Feel free to patch it.
> 
> Gerrit Code Review, its open source, so you can try to patch it, but
> I can understand why someone wouldn't want to poke it themselves.
> Its a hairy ball of technologies that produces a 14 MB WAR file.
> Nothing good can ever come of that...

Scary since the check would be useful in Gerrit.

-- robin