| [egit-dev] Need code review, Fwd: [Bug 297584] The egit core bundle has UI dependencies. |
Hi, We have a bug [1] about the dependency in org.eclipse.egit.core to org.eclipse.ui bunlde. This bug prevents Buckminster from providing headless Git support for M6 [2], [3]. Thomas Hallgren (CC'ed) tried the proposed fix and it looks ok [4]. And they are still waiting (now they are M6 +3). What should be done? Well, I can commit these changes by myself without any review but I don't want to do so. So, please review proposed changes as they need 'Code Review +2' : - http://egit.eclipse.org/r/357 - http://egit.eclipse.org/r/358 - http://egit.eclipse.org/r/359 - http://egit.eclipse.org/r/360 [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=297584 [2] http://dev.eclipse.org/mhonarc/lists/egit-dev/msg00951.html [3] https://bugs.eclipse.org/bugs/show_bug.cgi?id=297584#c6 [4] https://bugs.eclipse.org/bugs/show_bug.cgi?id=297584#c13 ---------- Forwarded message ---------- From: <bugzilla-daemon@xxxxxxxxxxx> Date: Wed, Mar 17, 2010 at 9:12 AM Subject: [Bug 297584] The egit core bundle has UI dependencies. https://bugs.eclipse.org/bugs/show_bug.cgi?id=297584 Product/Component: EGit / Core --- Comment #15 from Thomas Hallgren <thomas@xxxxxxx> 2010-03-17 03:12:51 EDT --- (In reply to comment #14) > ... Thomas, does it still make sense fixing this ASAP? Absolutely. Given that the fix works, I moved Buckminster to +3 to be able to wait for the build where it is included. So I'm still waiting :-) -- Configure bugmail: https://bugs.eclipse.org/bugs/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.