[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[List Home]
|
[eclipselink-users] UnidirectionalOneToManyMapping yeesh!
|
- From: cowwoc <cowwoc@xxxxxxxxxxxxxxxx>
- Date: Thu, 30 Oct 2008 12:43:41 -0700 (PDT)
- Delivered-to: eclipselink-users@eclipse.org
Hi,
I ran across
http://wiki.eclipse.org/EclipseLink/Development/JPA2.0/uni-directional_onetomany_mapping
by chance. I wanted to take this opportunity to give some feedback ;)
The proposed code "smells" so bad I don't know where to begin. A few glaring
cosmetic issues:
1) Extremely long class names such as UnidirectionalOneToManyMapping and
UnidirectionalOneToManyRelationMaintanenceMode. What are you thinking?! In
my experience long names are usually a strong indication that something more
fundamental is wrong.
2) UnidirectionalOneToManyRelationMaintanenceMode.RemoveNowait versus
RemoveNoWait... It's annoying when people misuse camelCase :)
3) In my view, you are better off defining a new OneToMany in a new package
than creating these new classes.
Honestly, this page is freaking me out. If this is what JPA 2.0 is heading
towards then I foresee a lot of people jumping ship. Please keep JPA as
simple and clean as possible. Just my 2 cents :)
--
View this message in context: http://www.nabble.com/UnidirectionalOneToManyMapping-yeesh%21-tp20254023p20254023.html
Sent from the EclipseLink - Users mailing list archive at Nabble.com.