Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] [External] : EclipseLink 2.7.9 
Hi Will,

	I created another/alternative PR to Lukas fix https://github.com/eclipse-ee4j/eclipselink/pull/1182.

	My PR is https://github.com/eclipse-ee4j/eclipselink/pull/1183
	In my PR I wanted to keep naming compatibility with older bundles published at Eclipse.org pages.
	EclipseLink artifacts in eclipselink-plugins-*.zip are named in the same way as in 2.6, 2.7 bundles
	e.g. org.eclipse.persistence.core_2.7.9.v20210604-2c549e2208.jar	x	org.eclipse.persistence.core_3.0.2.v20210610-1fda5b4d4e.jar
	MANIFEST.MF content is changed too.
	Bundle-Version contains major.minor.micro.version.vYYYYMMDDHHmm e.g. Bundle-Version: 3.0.2.v202106101448
	plus new additional properties e.g.
		Implementation-Version: 3.0.2-SNAPSHOT
		Implementation-SCM-Revision: 1fda5b4d4e
		Implementation-SCM-Branch: 3.0

	Some note about bundles at Eclipse.org lifecycle.
	These bundles available at
	https://www.eclipse.org/eclipselink/downloads/nightly.php
	https://www.eclipse.org/eclipselink/downloads/milestones.php
	https://www.eclipse.org/eclipselink/downloads/
	are build during a nightly build.
	During promotion/release process are generated just Maven artifacts published at
	https://jakarta.oss.sonatype.org/content/groups/staging/org/eclipse/persistence/eclipselink/2.7.9/
	and later
	in the Maven Central.
	Bundles at Eclipse.org are just copied from Nightly to Milestones (e.g. RC1, MP1, ...) and Download (Final).
	This is reason why timestamp stored in bundles at Eclipse.org is usually older, than timestamp in artifacts stored in Maven Central.

	About 2.7.9 Final:
		This version is available in staging see e.g. https://jakarta.oss.sonatype.org/content/groups/staging/org/eclipse/persistence/eclipselink/2.7.9/
		Please let us know if any change is required there.
		If not we will release it into Maven Central. I think tomorrow or during weekend.

Thanks
Radek

On 6/9/21 11:45 PM, Lukas Jungmann wrote:

Hi,
  I think I got your point. Can you try the zip from https://urldefense.com/v3/__https://github.com/eclipse-ee4j/eclipselink/pull/1182__;!!GqivPVa7Brio!Il8CZQ5bBAlqE4cFzaybOmzY61uM0CUXlC48wP90Fz87_udVZWkIz_EW3HUlBEdWpmw$ , please? 

thanks,
--lukas

On 6/8/21 6:15 PM, William Dazey wrote:

Hello!

Ignore my previous email. I accidentally hit the send button early.

On Tue, Jun 8, 2021 at 10:25 AM Lukas Jungmann
<lukas.jungmann@xxxxxxxxxx> wrote:


so this is perhaps what you want to double check:
https://urldefense.com/v3/__http://www.eclipse.org/downloads/download.php?file=*rt*eclipselink*milestones*3.0.2*RC1*eclipselink-plugins-3.0.2.v20210604-e7fc271759.zip__;Ly8vLy8v!!GqivPVa7Brio!Lowt5JfuBcLlxfzK_AZElM2MoERuWcwJUuOSwc6aL4wiPkGc6J_S-uS3rJdzauKQj0A$ 

reachable from https://urldefense.com/v3/__https://www.eclipse.org/eclipselink/downloads/milestones.php__;!!GqivPVa7Brio!Lowt5JfuBcLlxfzK_AZElM2MoERuWcwJUuOSwc6aL4wiPkGc6J_S-uS3rJdzsks0sos$


At first glance, it looks like this is better. I will still need to
upload to our builds to make sure everything checks out properly.

I did have two notes:

1) The individual bundle names

`eclipselink-plugins-3.0.2.v20210604-e7fc271759/org.eclipse.persistence.core_3.0.2.v202106042222.jar`

Compared to 2.7.8 from eclipse downloads.
`eclipselink-plugins-2.7.8.v20201217-ecdf3c32c4/org.eclipse.persistence.core_2.7.8.v20201217-ecdf3c32c4.jar`

Do we mean to use the qualifier "v202106042222" for 3.0.2 artifacts?
In the past, YYYY/MM/DD format seemed to be enough, to we need the
timestamp too? Also, we are not including the git hash? It was a bit
useful personally to know what commit that build matches up to.

2) The manifest `Bundle-Version`

eclipselink-plugins-3.0.2.v20210604-e7fc271759/org.eclipse.persistence.core_3.0.2.v202106042222.jar/META-INF/MANIFEST.MF:
```
     Bundle-Version: 3.0.2.SNAPSHOT
```

Compared to 3.0.2-RC1 on central.
org.eclipse.persistence.core-3.0.2-RC1.jar/META-INF/MANIFEST.MF:
```
     Bundle-Version: 3.0.2.RC1
```

Compared to 2.7.8 from eclipse downloads.
eclipselink-plugins-2.7.8.v20201217-ecdf3c32c4/org.eclipse.persistence.core_2.7.8.v20201217-ecdf3c32c4.jar/META-INF/MANIFEST.MF:
```
     Bundle-Version: 2.7.8.v20201217-ecdf3c32c4
```

Do we mean to call the 3.0.2 a SNAPSHOT? I don't know if this is wrong
per-say, but it is a difference I noticed and want to bring it up in
case it isn't supposed to look like this.

Thanks,
Will Dazey
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/eclipselink-dev__;!!GqivPVa7Brio!Lowt5JfuBcLlxfzK_AZElM2MoERuWcwJUuOSwc6aL4wiPkGc6J_S-uS3rJdzxvcYETk$



_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/eclipselink-dev__;!!GqivPVa7Brio!Il8CZQ5bBAlqE4cFzaybOmzY61uM0CUXlC48wP90Fz87_udVZWkIz_EW3HUljXU8qFE$

Back to the top