Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] [External] : EclipseLink 3.0.1 bundle 
Hello Radek!

I think there may be a bigger problem in the build process and not
just packaging. Looking at the manifest files, it seems that the
package version is incorrect too:

org.eclipse.persistence.core_3.0.1.qualifier.jar/META-INF/MANIFEST.MF
```
...
    org.eclipse.persistence.transaction;uses:="jak
 arta.transaction,org.eclipse.persistence.exceptions,org.eclipse.persi
 stence.internal.sequencing,org.eclipse.persistence.internal.sessions,
 org.eclipse.persistence.sessions";version="3.0.2",org.eclipse.persist
 ence.transaction.glassfish;uses:="jakarta.transaction,org.eclipse.per
 sistence.exceptions,org.eclipse.persistence.transaction";version="3.0
 .2",org.eclipse.persistence.transaction.jboss;uses:="jakarta.transact
 ion,org.eclipse.persistence.exceptions,org.eclipse.persistence.transa
 ction";version="3.0.2",org.eclipse.persistence.transaction.jotm;uses:
 ="jakarta.transaction,org.eclipse.persistence.transaction";version="3
 .0.2",org.eclipse.persistence.transaction.oc4j;uses:="jakarta.transac
 tion,org.eclipse.persistence.transaction";version="3.0.2",org.eclipse
 .persistence.transaction.sap;uses:="jakarta.transaction,org.eclipse.p
 ersistence.transaction";version="3.0.2",org.eclipse.persistence.trans
 action.was;uses:="jakarta.transaction,org.eclipse.persistence.transac
 tion";version="3.0.2",org.eclipse.persistence.transaction.wls;uses:="
 jakarta.transaction,org.eclipse.persistence.exceptions,org.eclipse.pe
 rsistence.transaction";version="3.0.2"
Bundle-Name: EclipseLink Core
Bundle-Version: 3.0.2.SNAPSHOT
```
This is totally wrong and means that these bundles need to be rebuilt.

I also went out to maven central
(https://mvnrepository.com/artifact/org.eclipse.persistence/org.eclipse.persistence.core/3.0.1)
and it appears that those binaries are fine:

org.eclipse.persistence.core-3.0.1.jar
```
...
    org.eclipse.persistence.transaction;uses:="jak
 arta.transaction,org.eclipse.persistence.exceptions,org.eclipse.persi
 stence.internal.sequencing,org.eclipse.persistence.internal.sessions,
 org.eclipse.persistence.sessions";version="3.0.1",org.eclipse.persist
 ence.transaction.glassfish;uses:="jakarta.transaction,org.eclipse.per
 sistence.exceptions,org.eclipse.persistence.transaction";version="3.0
 .1",org.eclipse.persistence.transaction.jboss;uses:="jakarta.transact
 ion,org.eclipse.persistence.exceptions,org.eclipse.persistence.transa
 ction";version="3.0.1",org.eclipse.persistence.transaction.jotm;uses:
 ="jakarta.transaction,org.eclipse.persistence.transaction";version="3
 .0.1",org.eclipse.persistence.transaction.oc4j;uses:="jakarta.transac
 tion,org.eclipse.persistence.transaction";version="3.0.1",org.eclipse
 .persistence.transaction.sap;uses:="jakarta.transaction,org.eclipse.p
 ersistence.transaction";version="3.0.1",org.eclipse.persistence.trans
 action.was;uses:="jakarta.transaction,org.eclipse.persistence.transac
 tion";version="3.0.1",org.eclipse.persistence.transaction.wls;uses:="
 jakarta.transaction,org.eclipse.persistence.exceptions,org.eclipse.pe
 rsistence.transaction";version="3.0.1"
Bundle-Name: EclipseLink Core
Bundle-Version: 3.0.1
```

Thanks,
Will Dazey

On Tue, May 4, 2021 at 2:23 AM Radek Felcman <radek.felcman@xxxxxxxxxx> wrote:
>
> Hi Will,
>
>         thank You for the information. It looks, that there is some bug in https://github.com/eclipse-ee4j/eclipselink/tree/master/bundles part.
>         I created bug for this https://github.com/eclipse-ee4j/eclipselink/issues/1107
>         As I checked, content published at Maven Central is OK. Just content produced by Nightly builds and published at https://www.eclipse.org/eclipselink/downloads/nightly.php is incorrect.
>
> Thank You
> Radek
>
> On 5/3/21 9:34 PM, William Dazey wrote:
> > Hello!
> >
> > I downloaded the EclipseLink 3.0.1 OSGi Bundles Zip
> > (https://urldefense.com/v3/__https://www.eclipse.org/downloads/download.php?file=*rt*eclipselink*releases*3.0.1*eclipselink-plugins-3.0.1.v20210407-569c89c116.zip__;Ly8vLy8!!GqivPVa7Brio!NKce5fSyCosRLqqM0BNpBiYi6eHbMXD3GYTZcdnpH1k1m46Hi35Qe89U7Jzy1M1MsjE$ ).
> >
> > However, looking at the artifacts within, I am a bit confused if the
> > content is correct. It seems to me that the packaging might be
> > incorrect. I am primarily comparing this release with 2.7.8
> > (https://urldefense.com/v3/__https://www.eclipse.org/downloads/download.php?file=*rt*eclipselink*releases*2.7.8*eclipselink-plugins-2.7.8.v20201217-ecdf3c32c4.zip__;Ly8vLy8!!GqivPVa7Brio!NKce5fSyCosRLqqM0BNpBiYi6eHbMXD3GYTZcdnpH1k1m46Hi35Qe89U7JzyHkkf0lI$ )
> >
> >
> > For instance, here are some of the files:
> >
> > ```
> >      org.eclipse.persistence.asm_7.0.0.v201811131354.jar
> >      org.eclipse.persistence.asm-3.0.2-SNAPSHOT.jar
> >      org.eclipse.persistence.asm-3.0.2-SNAPSHOT-sources.jar
> >      ...
> >      org.eclipse.persistence.core_3.0.1.qualifier.jar
> >      org.eclipse.persistence.core-3.0.2-SNAPSHOT.jar
> >      org.eclipse.persistence.core-3.0.2-SNAPSHOT-sources.jar
> > ```
> >
> > 1) It would appear that we are packaging both 3.0.1 and a 3.0.2
> > SNAPSHOT in this down. Is there a reason for this? It looks like a
> > mistake and seems unnecessary to me.
> >
> > 2) We are including the source, which is consistent with other
> > releases, but again, it looks to be against some SNAPSHOT and not
> > `569c89c116`, which is supposed to be the hash.
> >
> > 3) The `3.0.1` release has a `qualifier` on the end instead of the
> > actual release hash. This is inconsistent with other releases, such as
> > the 2.7.8 release I posted above. I can crack open the
> > version.properties file and see that the release appears to be
> > correct, but the artifacts were all incorrectly named.
> > ```
> >      buildRevision=569c89c116681feda6873c9b96042b3e732ea77d
> > ```
> >
> > I would appreciate any input.
> >
> > Thanks,
> > Will Dazey
> > _______________________________________________
> > eclipselink-dev mailing list
> > eclipselink-dev@xxxxxxxxxxx
> > To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/eclipselink-dev__;!!GqivPVa7Brio!NKce5fSyCosRLqqM0BNpBiYi6eHbMXD3GYTZcdnpH1k1m46Hi35Qe89U7Jzyn9009Vc$
> >

Back to the top