Re: [eclipselink-dev] Review for 527085

[Bo Liu <bo.l.liu@xxxxxxxxxx>]

William, sorry I'm the one jumping out to reject this change, add the git.hash into the version string is not acceptable. for example as the consequence of your change, we would attempt to upload such version of eclipselink bits to nexus:

2.7.1-$(git.hash}-SNAPSHOT

2.7.1-${git.hash}-RC1

Liu Bo

On 11/10/17 7:12, William Dazey wrote:

I would appreciate a code review for https://bugs.eclipse.org/bugs/show_bug.cgi?id=527085

Its a relatively small change, but I would like to know if anyone has objections with the changes.

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipselink-2Ddev&d=DwICAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=XWSWwV04cbSI7ylGAvY6jseEOAHf64cXl73jrzI_zxs&m=C7C2C2IeVTUnuyWJI3qD9-Z5ogCN-UvZdGpS0egTd2U&s=fe5jAkx7KsuPzncUsuymIh_NTYjqdJIF0X2cG6BTkM8&e=