Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] Unification of line endings in the codebase

Hello,

As an IntelliJ IDEA user, I can confirm that this file can be used as is with the Eclipse Code Formatter plugin.
It can also be setup to automatically be applied on commit, however I found that existing code does not uniformly use the formatting conventions so there appear additional changes in the file. I personally only apply the code formatter manually to lines of code which I edit.

Kind regards,
Petros Splinakis

-----Original Message-----
From: Lukas Jungmann 
Sent: Thursday, March 19, 2015 10:36 AM
To: Dev mailing list for Eclipse Persistence Services
Subject: Re: [eclipselink-dev] Unification of line endings in the codebase

On 3/18/15 4:03 PM, gordon yorke wrote:
> There is an Eclipse format file in the repository under 
> project-admin/EclipseLink-Eclipse-Format.xml that represents the 
> EclipseLink format standard that has been in place for a very long 
> time.  I am not sure how helpful this is to non Eclipse users.

true but times are changing and eclipse users are becoming to be minority of the devs. Other thing is that this file does have nothing to do with line endings, it only defines general formatting rules.
Perhaps someone using other ide(s) could prepare sth similar for that ide?

thanks,
--lukas
> --Gordon
>
>
> On 18/03/2015 5:48 AM, Lukas Jungmann wrote:
>> Hi all,
>>
>>    currently eclipselink sources contains mix of line endings - some 
>> files are using *nix style (LF), some win style (CRLF) and the rest 
>> is a mix of *nix and win style (some lines end with LF while others 
>> with CRLF). Since we are at the beginning of 2.7 development it looks 
>> like a good time to me to unify line endings in our codebase to avoid 
>> complete rewrites of files in the future.
>>
>> Why we should do that?
>> -make it easier to review incoming as well as own (outgoing) changes 
>> -avoid noise in git log -use 
>> https://help.github.com/articles/dealing-with-line-endings as a guide 
>> to properly set up local development environment
>>
>> Drawbacks:
>> -one-time full rewrite of some files in the repository -some 
>> backports to previous streams will require manual changes/merges
>>
>> When?
>>   if there will be an agreement, I'd like to perform the change next 
>> week, on Friday March 27, 2015
>>
>> Which line endings should be used?
>>   either *nix or win but definitely not a mix of them in one file
>>
>> How to cast your vote?
>>   simply reply to this email with either '+LF', '+CRLF' or 'Leave it 
>> as it is' by Thursday March 28, 23:59.
>>
>> Thanks and happy voting,
>> --lukas
>> _______________________________________________
>> eclipselink-dev mailing list
>> eclipselink-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or 
>> unsubscribe from this list, visit 
>> https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
>
> _______________________________________________
> eclipselink-dev mailing list
> eclipselink-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or 
> unsubscribe from this list, visit 
> https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/eclipselink-dev


Back to the top