Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] Index support

Hi James, Tom,

 

We’ve completed the change and included it with other changes required to pass the core and JPA tests on SymfowarePlatform.

Please see the attachment to:

 

https://bugs.eclipse.org/bugs/show_bug.cgi?id=339458

 

Once it’s been reviewed and committed we’ll update the wiki on SymfowarePlatform to update this platform’s limitations.

 

Thanks,

Dies

 

From: eclipselink-dev-bounces@xxxxxxxxxxx [mailto:eclipselink-dev-bounces@xxxxxxxxxxx] On Behalf Of James Sutherland
Sent: Monday, 11 April 2011 22:21
To: Dev mailing list for Eclipse Persistence Services
Cc: Noman, Abdullah
Subject: Re: [eclipselink-dev] Index support

 

Hello Dies,

  You can go ahead and make the necessary changes.  I can review the changes.

-----Original Message-----
From: Koper, Dies [mailto:diesk@xxxxxxxxxxxxxxxxxxx]
Sent: Sunday, April 10, 2011 10:32 PM
To: Dev mailing list for Eclipse Persistence Services
Cc: Noman, Abdullah
Subject: Re: [eclipselink-dev] Index support

Hi James,

 

It took a while and we ran into a few other issues too but finally completed these tests.

Here’s what was broken:

 

Symfoware has its own CREATE INDEX syntax, so I created DatabasePlatform#buildCreateIndex and overrode it in SymfowarePlatform last year.

You added a new class IndexDefinition that has its own buildCreationWriter method, building the CREATE INDEX statement in an incompatible way.

Is there any particular reason you didn’t just reuse/change DatabasePlatform#buildCreateIndex?

 

Now we have code to create this statement in both IndexDefinition#buildCreationWriter and DatabasePlatform#buildCreateIndex.

To clean this up and fix it for Symfoware, I’d prefer IndexDefinition#buildCreationWriter to delegate to DatabasePlatform#buildCreateIndex, changing its signature to accept the unique flag.

Similar for buildDeletionWriter.

 

Are you okay with us making this change, or do you want to do it yourself and we create a patch for SymfowarePlatform that fixes any Symfoware specific issues afterwards?

 

Thanks,

Dies

 

 

From: eclipselink-dev-bounces@xxxxxxxxxxx [mailto:eclipselink-dev-bounces@xxxxxxxxxxx] On Behalf Of James Sutherland
Sent: Monday, 30 August 2010 22:30
To: Dev mailing list for Eclipse Persistence Services
Subject: Re: [eclipselink-dev] Index support

 

0 DocumentEmail

Hi Dies,

  I am refactoring the Symfoware auto index support under the new index support.  If you could run the tests on Symfoware when I am done to ensure I did not break anything, that would be great.

-----Original Message-----
From: Koper, Dies [mailto:diesk@xxxxxxxxxxxxxxxxxxx]
Sent: Thursday, August 26, 2010 9:20 PM
To: Dev mailing list for Eclipse Persistence Services
Subject: Re: [eclipselink-dev] Index support

Hi James,

 

As you may know I added some code half a year ago to have indices generated for primary key columns for SymfowarePlatform.

Indices on primary keys are mandatory and not created automatically on this platform.

I hope your design will take that into account (i.e. e.g. not create duplicate indices for primary keys that have an @Index annotation).

 

Thanks!

Dies

 

 

From: eclipselink-dev-bounces@xxxxxxxxxxx [mailto:eclipselink-dev-bounces@xxxxxxxxxxx] On Behalf Of James Sutherland
Sent: Friday, 27 August 2010 02:28
To: Eclipselink-Dev@Eclipse. Org (E-mail)
Subject: [eclipselink-dev] Index support

 

Normal 0 DocumentEmail

I am working on adding database index DDL generation support for 2.2,

See,

http://wiki.eclipse.org/EclipseLink/DesignDocs/283430


Back to the top