Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] fix for bug 333160 
Fix checked into SVN rev# 8763
https://fisheye2.atlassian.com/changelog/eclipselink/?cs=8763

2.2 backport is pending approval
/michael
333160: JMX: ModuleName string extraction code does not handle -1 not found index in 3 of 5 cases 
http://wiki.eclipse.org/EclipseLink/DesignDocs/316513#WebSphere_Application_and_Module_Name_extraction
https://bugs.eclipse.org/bugs/attachment.cgi?id=185810&action=diff
http://dev.eclipse.org/mhonarc/lists/eclipselink-dev/msg05294.html
Fix := some of the subString(indexOf(...)) string manipulation for JMX module/application name strings based on classLoader strings - did not handle the "not found" case for indexOf() == -1 during container session deploys of mixed EAR(EJB/WAR)/WAR-only-EAR apps.
Regression Testing: (same unchanged results as a separate clean view - both on Derby 10.5.3 off of SVN rev# 8762) 
>clean view
CORE
[junit] [EL Info]: 2011-01-01 14:56:26.434--DatabaseSessionImpl(32222156)-- login successful [junit] Tests run: 3159, Failures: 0, Errors: 45, Time elapsed: 461.648 sec 
   [junit] Test org.eclipse.persistence.testing.tests.TestRunModel FAILED
[junitreport] Processing F:\view_w35g\foundation\eclipselink.core.test\reports\TESTS-TestSuites.xml to F:\view_w35g\foundation\eclipselink.core.test\reports\junit-noframes.html 
BUILD SUCCESSFUL
Total time: 7 minutes 44 seconds

JPA
<testsuite errors="52" failures="39" hostname="xps435" name="org.eclipse.persistence.testing.tests.jpa.AllCMP3TestRunModel" tests="2219" time="529.01" timestamp="2011-01-01T21:50:45"> 

>modified view
CORE
[junit] [EL Info]: 2011-01-01 12:52:18.922--DatabaseSessionImpl(10344402)--EclipseLink, version: Eclipse Persistence Services - 2.3.0.qualifier [junit] [EL Info]: 2011-01-01 12:52:18.953--DatabaseSessionImpl(10344402)-- login successful [junit] Tests run: 3159, Failures: 0, Errors: 45, Time elapsed: 464.76 sec 
   [junit] Test org.eclipse.persistence.testing.tests.TestRunModel FAILED
[junitreport] Processing F:\view_w35e\foundation\eclipselink.core.test\reports\TESTS-TestSuites.xml to F:\view_w35e\foundation\eclipselink.core.test\reports\junit-noframes.html 
BUILD SUCCESSFUL
Total time: 7 minutes 52 seconds

JPA
<testsuite errors="52" failures="39" hostname="xps435" name="org.eclipse.persistence.testing.tests.jpa.AllCMP3TestRunModel" tests="2219" time="526.747" timestamp="2011-01-01T20:19:41">
Command: Commit Modified: F:\view_w35e\foundation\org.eclipse.persistence.core\src\org\eclipse\persistence\platform\server\JMXServerPlatformBase.java Modified: F:\view_w35e\foundation\org.eclipse.persistence.core\src\org\eclipse\persistence\platform\server\jboss\JBossPlatform.java Modified: F:\view_w35e\foundation\org.eclipse.persistence.core\src\org\eclipse\persistence\platform\server\sunas\SunAS9ServerPlatform.java Modified: F:\view_w35e\foundation\org.eclipse.persistence.core\src\org\eclipse\persistence\platform\server\wls\WebLogic_10_Platform.java Sending content: F:\view_w35e\foundation\org.eclipse.persistence.core\src\org\eclipse\persistence\platform\server\wls\WebLogic_10_Platform.java Sending content: F:\view_w35e\foundation\org.eclipse.persistence.core\src\org\eclipse\persistence\platform\server\JMXServerPlatformBase.java Sending content: F:\view_w35e\foundation\org.eclipse.persistence.core\src\org\eclipse\persistence\platform\server\jboss\JBossPlatform.java Sending content: F:\view_w35e\foundation\org.eclipse.persistence.core\src\org\eclipse\persistence\platform\server\sunas\SunAS9ServerPlatform.java 
Completed: At revision: 8763


Michael O'Brien wrote:
A patch file for bug 333160 is now available for review until at least Wed 29 Dec. 

https://bugs.eclipse.org/bugs/attachment.cgi?id=185810&action=diff
http://bugs.eclipse.org/333160
Fix := some of the subString(indexOf(...)) string manipulation for JMX module/application name strings based on classLoader strings - did not handle the "not found" case for indexOf() == -1 during container session deploys of mixed EAR(EJB/WAR)/WAR-only-EAR apps. 

Please review and provide any feedback.

thank you
/michael


>Container testing results

>WebSphere 7.0.0.5
http://127.0.0.1:9080/enterprise/FrontController?action=demo
[12/24/10 11:20:40:883 EST] 00000013 SystemOut O [EL Finest]: 2010-12-24 11:20:40.883--ServerSession(1702651260)--Thread(Thread[WebContainer : 0,5,main])--EclipseLink JMX Runtime Services is referencing the [Platform ConversionManager] ClassLoader at: [ com.ibm.ws.classloader.CompoundClassLoader@fd80fd8[app:org.eclipse.persistence.example.jpa.server.websphere.EnterpriseEAR] Local ClassPath: C:\opt\was7b\AppServer\profiles\AppSrv01\installedApps\xps435Node01Cell\org.eclipse.persistence.example.jpa.server.websphere.EnterpriseEAR.ear\org.eclipse.persistence.example.jpa.server.websphere.EnterpriseEJB.jar;C:\opt\was7b\AppServer\profiles\AppSrv01\installedApps\xps435Node01Cell\org.eclipse.persistence.example.jpa.server.websphere.EnterpriseEAR.ear\org.eclipse.persistence.example.jpa.server.entities.jar 
  Parent: com.ibm.ws.classloader.ProtectionClassLoader@3a1d3a1d
  Delegation Mode: PARENT_FIRST]
[12/24/10 11:20:40:884 EST] 00000013 SystemOut O [EL Finest]: 2010-12-24 11:20:40.883--ServerSession(1702651260)--Thread(Thread[WebContainer : 0,5,main])--The applicationName for the MBean attached to session [jar:file:/C:/opt/was7b/AppServer/profiles/AppSrv01/installedApps/xps435Node01Cell/org.eclipse.persistence.example.jpa.server.websphere.EnterpriseEAR.ear/org.eclipse.persistence.example.jpa.server.websphere.EnterpriseEJB.jar!/_example] is [org.eclipse.persistence.example.jpa.server.websphere.EnterpriseEAR] [12/24/10 11:20:40:884 EST] 00000013 SystemOut O [EL Finest]: 2010-12-24 11:20:40.884--ServerSession(1702651260)--Thread(Thread[WebContainer : 0,5,main])--The moduleName for the MBean attached to session [jar:file:/C:/opt/was7b/AppServer/profiles/AppSrv01/installedApps/xps435Node01Cell/org.eclipse.persistence.example.jpa.server.websphere.EnterpriseEAR.ear/org.eclipse.persistence.example.jpa.server.websphere.EnterpriseEJB.jar!/_example] is [_example] 

>JBoss 5 EAP
http://127.0.0.1:8080/enterprise/FrontController?action=demo
this JBossPlatform (id=373) databaseSessionName "vfszip_/C_/opt/jboss-eap-5.0b/jboss-as/server/default/deploy/org.eclipse.persistence.example.jpa.server.jboss.EnterpriseEAR.ear/org.eclipse.persistence.example.jpa.server.jboss.EnterpriseEJB.jar/_example2" (id=464) classLoaderName "BaseClassLoader@19c4f4e{vfszip:/C:/opt/jboss-eap-5.0b/jboss-as/server/default/deploy/org.eclipse.persistence.example.jpa.server.jboss.EnterpriseEAR.ear/}" (id=466) 11:09:18,711 INFO [STDOUT] [EL Finest]: 2010-12-24 11:09:18.709--ServerSession(29051400)--Thread(Thread[http-127.0.0.1-8080-2,5,jboss])--The applicationName for the MBean attached to session [vfszip:/C:/opt/jboss-eap-5.0b/jboss-as/server/default/deploy/org.eclipse.persistence.example.jpa.server.jboss.EnterpriseEAR.ear/org.eclipse.persistence.example.jpa.server.jboss.EnterpriseEJB.jar/_example2] is [org.eclipse.persistence.example.jpa.server.jboss.EnterpriseEAR.ear] 11:09:19,662 INFO [STDOUT] [EL Finest]: 2010-12-24 11:09:19.66--ServerSession(29051400)--Thread(Thread[http-127.0.0.1-8080-2,5,jboss])--The moduleName for the MBean attached to session [vfszip:/C:/opt/jboss-eap-5.0b/jboss-as/server/default/deploy/org.eclipse.persistence.example.jpa.server.jboss.EnterpriseEAR.ear/org.eclipse.persistence.example.jpa.server.jboss.EnterpriseEJB.jar/_example2] is [_example2] 

>WebLogic 10.3.3.0
http://127.0.0.1:7001/enterprise/FrontController?action=demo
[EL Finest]: 2010-12-24 11:14:06.683--ServerSession(15892568)--Thread(Thread[[ACTIVE] ExecuteThread: '0' for queue: 'weblogic.kernel.Default (self-tuning)',5,Pooled Threads])--The applicationName for the MBean attached to session [file:/F:/view_w35e/examples/org.eclipse.persistence.example.jpa.server.weblogic.enterpriseEJB/build/classes/_example] is [org.eclipse.persistence.example.jpa.server.weblogic.enterpriseEAR] [EL Finest]: 2010-12-24 11:14:06.683--ServerSession(15892568)--Thread(Thread[[ACTIVE] ExecuteThread: '0' for queue: 'weblogic.kernel.Default (self-tuning)',5,Pooled Threads])--The moduleName for the MBean attached to session [file:/F:/view_w35e/examples/org.eclipse.persistence.example.jpa.server.weblogic.enterpriseEJB/build/classes/_example] is [enterprise] 


>Test Fail Fast: Exception condition output
(Test case: introduce a forced NPE in the code - temporarily for testing)
10:16:04,454 INFO [STDOUT] [EL Finest]: 2010-12-24 10:16:04.452--ServerSession(4286345)--Thread(Thread[http-127.0.0.1-8080-2,5,jboss])--The applicationName for the MBean attached to session [BaseClassLoader@43d24e{vfszip:/C:/opt/jboss-eap-5.0b/jboss-as/server/default/deploy/org.eclipse.persistence.example.jpa.server.jboss.EnterpriseEAR.ear/}] is [unavailable] 10:16:09,945 INFO [STDOUT] [EL Finest]: 2010-12-24 10:16:09.944--ServerSession(4286345)--Thread(Thread[http-127.0.0.1-8080-2,5,jboss])--The moduleName for the MBean attached to session [vfszip_/C_/opt/jboss-eap-5.0b/jboss-as/server/default/deploy/org.eclipse.persistence.example.jpa.server.jboss.EnterpriseEAR.ear/org.eclipse.persistence.example.jpa.server.jboss.EnterpriseEJB.jar/_example2] is [unavailable] 
10:16:46,845 ERROR [STDERR] java.lang.NullPointerException
10:16:46,846 ERROR [STDERR] at org.eclipse.persistence.platform.server.JMXServerPlatformBase.initializeApplicationNameAndModuleName(JMXServerPlatformBase.java:527) 

thank you
/michael

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

Back to the top