Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] fix for bug 325605

Update,
The category cutoff for "no SQL tracking" needs to be reduced to FINEST as 20 tests in the JPA suite rely on SQL statement tracking of at least the FINE level. Or we can modify JPA/Core to log SQL Statements only above FINE.

   This patch is the same as the previous but with a single line change
-                && entry.getLevel() > SessionLog.FINE) {
+                && entry.getLevel() > SessionLog.FINEST) {

>for example jpql.testFetchGroups() logs at FINE == 3 which is not compatible with a filter cutoff at the FINE level entry SessionLogEntry (id=1299) level 3 message "SELECT t0.EMP_ID, t0.F_NAME, t0.L_NAME, t0.VERSION FROM CMP3_EMPLOYEE t0, CMP3_SALARY t1 WHERE ((t0.EMP_ID = ?) AND (t1.EMP_ID = t0.EMP_ID))\r\n\tbind => [9557]" (id=1311) nameSpace "sql" (id=1314) Thread [Thread-1121] (Suspended (breakpoint at line 67 in QuerySQLTracker)) QuerySQLTracker.log(SessionLogEntry) line: 67 ServerSession(AbstractSession).log(SessionLogEntry) line: 2665 ServerSession(AbstractSession).log(int, String, String, Object[], Accessor, boolean) line: 3777 DatabaseAccessor.basicExecuteCall(Call, AbstractRecord, AbstractSession) line: 572 DatabaseAccessor.executeCall(Call, AbstractRecord, AbstractSession) line: 526 ServerSession.executeCall(Call, AbstractRecord, DatabaseQuery) line: 530 JPQLCallQueryMechanism(DatasourceCallQueryMechanism).executeCall(DatasourceCall) line: 206 JPQLCallQueryMechanism(DatasourceCallQueryMechanism).executeCall() line: 192 JPQLCallQueryMechanism(DatasourceCallQueryMechanism).selectOneRow() line: 664 JPQLCallQueryMechanism(ExpressionQueryMechanism).selectOneRowFromTable() line: 2603 JPQLCallQueryMechanism(ExpressionQueryMechanism).selectOneRow() line: 2574 ReadObjectQuery.executeObjectLevelReadQuery() line: 444 ReadObjectQuery(ObjectLevelReadQuery).executeDatabaseQuery() line: 1080 ReadObjectQuery(DatabaseQuery).execute(AbstractSession, AbstractRecord) line: 782 ReadObjectQuery(ObjectLevelReadQuery).execute(AbstractSession, AbstractRecord) line: 1040 ReadObjectQuery.execute(AbstractSession, AbstractRecord) line: 412 ReadObjectQuery(ObjectLevelReadQuery).executeInUnitOfWork(UnitOfWorkImpl, AbstractRecord) line: 1126 RepeatableWriteUnitOfWork(UnitOfWorkImpl).internalExecuteQuery(DatabaseQuery, AbstractRecord) line: 2960 RepeatableWriteUnitOfWork(AbstractSession).executeQuery(DatabaseQuery, AbstractRecord, int) line: 1303 RepeatableWriteUnitOfWork(AbstractSession).executeQuery(DatabaseQuery, AbstractRecord) line: 1285 RepeatableWriteUnitOfWork(AbstractSession).executeQuery(DatabaseQuery, List) line: 1259 EJBQueryImpl<X>.executeReadQuery() line: 484 EJBQueryImpl<X>.getSingleResult() line: 772 AdvancedQueryTestSuite.testFetchGroups() line: 292

>results at FINEST
<testsuite errors="0" failures="0" hostname="xps435" name="org.eclipse.persistence.testing.tests.jpa.AllCMP3TestRunModel" tests="2176" time="514.914" timestamp="2010-11-23T21:06:09">


   We can discuss this tomorrow.
   thank you
   /michael
Michael O'Brien wrote:
A patch file for bug 325606 is now available for review.

https://bugs.eclipse.org/bugs/attachment.cgi?id=183711&action=diff

After a review by Doug and Peter.
thank you
/michael

Michael O'Brien wrote:
A patch file for bug 325605 is now available for review

Description: DB2 9.7 Universal fails a single cascade test from 324341 because SQL Warnings are being tracked as SQL Statements in the QuerySQLTracker subclass of AbstractSessionLog. Fix is to add new sessionLog SQL_WARNING category and use it in databaseAccessor.basicExecuteCall().

Please review and provide any feedback

>Regression test results: OK
<testsuite errors="0" failures="0" hostname="xps435" name="org.eclipse.persistence.testing.tests.jpa.AllCMP3TestRunModel" tests="2176" time="474.703" timestamp="2010-11-22T21:36:35">



_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev



Back to the top