Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] fix for bug 322008
The properties must be checked inside DatabaseQuery (or Expressions), not EJBQueryImpl (they must apply to all queries, not just JPA created queries).  Must check for Session properties, not EM (but EM properties should be Session properties).

JavaDoc should be nice html (<p> and <pre> for code).

Eventually the @AdditionalCriteria should also be supported on a mapping.


----- Original Message -----
From: gordon.yorke@xxxxxxxxxx
To: guy.pelletier@xxxxxxxxxx, eclipselink-dev@xxxxxxxxxxx
Sent: Tuesday, October 12, 2010 3:33:38 PM GMT -05:00 US/Canada Eastern
Subject: Re: [eclipselink-dev] fix for bug 322008

AdditionalCriteria.java:
    The Java Docs for AdditionalCriteria should not include implementation details (ie "and is appended with the following select...")
    I assume AdditionalCriteria is not supported with Native queries at all.
EntityManagerImpl.java
    setProperty is adding the property to the UOW twice.

How easily understood are the exceptions that are raised when the user does not provide the correct parameters to the query execution?  May want to update the code to throw a parameter failure specifically for the AdditionalCriteria

Otherwise looks good to me.
--Gordon


Guy Pelletier wrote:
A patch file for bug 322008 is now available for review.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=322008

Description: Improve usability of additional criteria applied to queries at the session/EM

Please review and provide any feedback.

Cheers,
Guy

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

Back to the top