Re: [eclipselink-dev] bug 327108 - ORDER column not part of the select l

[Tom Ware <tom.ware@xxxxxxxxxx>]

Hi Adrian,

  I am ok with the plan below.

  I prefer a blacklist because each time we add a database, it forces us to 
think about whether this is supported and whether it should be.

-Tom

Goerler, Adrian wrote:
> Hi Tom, Gordon,
>
> I understand that EclipseLink supports JPQL beyond the JPA spec. I also see the necessity to test this.
>
> However, the purpose of this test doesn't seem to be to check that you may order by a non-selectlist item.
>
> Instead, the topic of the test is "Complex COUNT on joined variable over ManyToMany self refrenceing relationship". It tests COUNT, not ORDER BY. I would not want to skip the COUNT-aspect of the test on MaxDB as MaxDB is not having an issue with the COUNT. Hence I am proposing to rewrite the query.
>
> Additionally, I'd like to propose to add a dedicated test that asserts that ORDER BY can be used on non-selectlist items. As this would be a feature beyond the spec that can't be expected on a database (with SQL92 dialect), I'd suggest to guard this test with a whitelist of supported databases. But I could also live with  a blacklist. 
>
> Best regards,
>
> Adrian
>
>
>
> SAP AG
> Dietmar-Hopp-Allee 16, 69190 Walldorf, Germany
>
> Sitz der Gesellschaft/Registered Office: Walldorf, Germany
> Vorstand/SAP Executive Board: Henning Kagermann (Sprecher/CEO), Léo Apotheker (stellvertretender Sprecher/Deputy CEO), Werner Brandt, Claus Heinrich, Gerhard Oswald, John Schwarz, Peter Zencke
> Vorsitzender des Aufsichtsrats/Chairperson of the SAP Supervisory Board: Hasso Plattner
> Registergericht/Commercial Register Mannheim No HRB 350269
>  
>
> > -----Ursprüngliche Nachricht-----
> > Von: eclipselink-dev-bounces@xxxxxxxxxxx 
> > [mailto:eclipselink-dev-bounces@xxxxxxxxxxx] Im Auftrag von Tom Ware
> > Gesendet: Mittwoch, 6. Oktober 2010 16:36
> > An: Dev mailing list for Eclipse Persistence Services
> > Betreff: Re: [eclipselink-dev] bug 327108 - ORDER column not 
> > part of the select list
> >
> > Hi Adrian,
> >
> >    In general, we do not like to disable functionality that 
> > allows us to do more 
> > than the specification allows.  I suggest, instead, skipping 
> > this test on MaxDB.
> >
> > -Tom
> >
> > Goerler, Adrian wrote:
> > > Hi Gordon,
> > >  
> > > _https://bugs.eclipse.org/bugs/show_bug.cgi?id=327108_
> > >  
> > > On MaxDB, the test 
> > JUnitJPQLComplexAggregateTestSuite.complexCountOnJoinedVariabl
> > eOverManyToManySelfRefRelationship 
> > > fails as a query is executed, which atempts to order by a 
> > column not 
> > > contained in the SELECT list. I am proposing to alter the 
> > query/test.
> > >  
> > > Could you please have a look?
> > >  
> > > Thanks and regards,
> > >  
> > > Adrian
> > >  
> > > SAP AG
> > > Dietmar-Hopp-Allee 16, 69190 Walldorf, Germany
> > >  
> > > Sitz der Gesellschaft/Registered Office: Walldorf, Germany
> > > Vorstand/SAP Executive Board: Henning Kagermann (Sprecher/CEO), Léo 
> > > Apotheker (stellvertretender Sprecher/Deputy CEO), Werner 
> > Brandt, Claus 
> > > Heinrich, Gerhard Oswald, John Schwarz, Peter Zencke
> > > Vorsitzender des Aufsichtsrats/Chairperson of the SAP 
> > Supervisory Board: 
> > > Hasso Plattner
> > > Registergericht/Commercial Register Mannheim No HRB 350269
> > >  
> > >  
> > --------------------------------------------------------------
> > ----------
> > > _______________________________________________
> > > eclipselink-dev mailing list
> > > eclipselink-dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
> > _______________________________________________
> > eclipselink-dev mailing list
> > eclipselink-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev