Re: [eclipselink-dev] SVN trunk Commit: Bug# 301599 - avoid m-m join, 22

[Mike Norman <michael.norman@xxxxxxxxxx>]

Last night's DBWS test failed due to the change from Collection to List:

compile:
    [javac] Compiling 8 source files to /net/stame10.us.oracle.com/scratch/aime/eclipselink/org.eclipse.persistence/trunk/dbws/eclipselink.dbws.test.oracle/classes
    [javac] /net/stame10.us.oracle.com/scratch/aime/eclipselink/org.eclipse.persistence/trunk/dbws/eclipselink.dbws.test.oracle/src/dbws/testing/oracleobjecttype/OracleObjecttypeTestSuite.java:449: cannot find symbol
    [javac] symbol  : method firstElement()
    [javac] location: interface java.util.List<org.eclipse.persistence.internal.descriptors.FieldTransformation>
    [javac]             (TransformerBasedFieldTransformation)versionMapping.getFieldTransformations().
    [javac]                                                                                          ^
    [javac] /net/stame10.us.oracle.com/scratch/aime/eclipselink/org.eclipse.persistence/trunk/dbws/eclipselink.dbws.test.oracle/src/dbws/testing/plsqlcollection/PLSQLcollectionTestSuite.java:177: cannot find symbol
    [javac] symbol  : method firstElement()
    [javac] location: interface java.util.List<org.eclipse.persistence.internal.descriptors.FieldTransformation>
    [javac]             (TransformerBasedFieldTransformation)versionMapping.getFieldTransformations().
    [javac]                                                                                          ^

    [javac] 2 errors

---

Mike Norman | Principal Software Designer
Phone: +6132884638 | | Fax: +6132382818 |
Oracle Oracle Server Technologies, EclipseLink Product
ORACLE Canada | 45 O'Connor Street, Suite 400, Ottawa, Ontario | K1P 1A4
Oracle is committed to developing practices and products that help protect the environment

On 24/08/2010 1:21 PM, James Sutherland wrote:

SVN trunk Commit: Bug# 301599 - avoid m-m join

 

https://bugs.eclipse.org/bugs/show_bug.cgi?id=301599

 

Avoid join from m-m join table to target table when only the id is compared.

 

Code review: Andrei

 

Changes:

- Optimize join in RelationExpression normalize for m-m id comparison, also avoid opt for 1-1 if a custom query mapping.

- Some micro opt, remvoed some dead code.

- Made ReadObjectQuery cache check only check the local unit of work cache, as the session cache is checked separately and was being checked twice.

- Changed AbstractDirectMapping to check for null and equality first to handle serialized objects correctly.

- Changed AbstractTransformationMapping

-- use List instead of Vector

-- fixed usage of indirection

-- mutable checks

-- compare byte arrays correctly

-- some cleanup, overrides

-- Avoid conforming in queries if the unit of work is empty.

-- Test for m-m join optimization.

 

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev