Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [eclipselink-dev] Fix for 307897 (JRockit+ASM issue) requires servlet jar (CQ 2505)

Mike and I did talk about this and, just to be clear, I stated that I believe we are good to do this from an IP perspective. 
 
I would like others to weigh in from a technical perspective.  My main concern is that we have introduced a DBWS dependency onto the Servlet jar, regardless of the usecase - and I believe removed the ASM dependency.  Which means that if we do this in 2.0.3, people upgrading will need to change the classpath to use DBWS.  Is that correct?
 
 
-----Original Message-----
From: Michael Norman
Sent: Friday, May 07, 2010 3:43 PM
To: Dev mailing list for Eclipse Persistence Services
Subject: [eclipselink-dev] Fix for 307897 (JRockit+ASM issue) requires servlet jar (CQ 2505)

https://bugs.eclipse.org/bugs/show_bug.cgi?id=307897

I have the fix for the JRockit+ASM issue (don't use ASM) where the source to _dbws.DBWSProvider is generated (as before)
then passed to the Java compiler using the javax.tools.JavaCompiler class. This fixes the problem for all combinations of JDK platforms.

There is one additional dependency which is that servlet.jar must be on the classpath when the DBWSBuilder is invoked.
We already have an approved CQ 2505 and we stated waay back in 1.1 that DBWS requires this (when DBWSBuilder was
an Ant task). Later DBWSBuilder was converted to a Java-main program and the provider class was generated using ASM
so we stopped shipping the jar.

I have spoken with Peter and he thinks we are in the clear to included it in 2.0.3 and 2.1 - any objections?

--
Mike Norman | Principal Software Designer | 613.288.4638
Oracle Server Technologies | EclipseLink Product
45 O'Connor Street, Suite 400 | Ottawa, ON K1P 1A4 | (fax) 613.238.2818

Back to the top