We should not be using the JPA IdClass by default. These classes will typically have very poor
performance, and commonly not implement equals and hashCode correctly. This should be a configurable option.
-----Original
Message-----
From: Gordon Yorke
Sent: Monday, January 18, 2010
10:06 AM
To: Dev mailing list for Eclipse Persistence
Services
Subject: Re: AW: [eclipselink-dev]
SVN main commit: bug#298985 - changing primary key from vector to object
The default for composite
PKs should depend on if JPA is used. With JPA we should be using the PK
class.
Also we need some sort of public policy class for the CacheInterceptor
implementations. This change is also breaking any CacheInterceptors that
have been created for previous version and we need some sort of migration plan.
--Gordon
James Sutherland wrote:
It will be configurable, for a singleton primary key object
it will just be the id value, i.e. Long, Integer, String, etc. For a composite
primary key object the default will be a CacheId object that wraps an
Object[]. It is also desirable to be able to use the JPA Id class as the
cache id.
-----Original
Message-----
From: Goerler, Adrian [mailto:adrian.goerler@xxxxxxx]
Sent: Friday, January 15, 2010
4:41 AM
To: Dev mailing list for Eclipse
Persistence Services
Subject: AW: [eclipselink-dev] SVN
main commit: bug#298985 - changing primary key from vector to object
Hi James,
(Vector
is still always used internally)
how
will the primary keys be represented once Vector is not used any longer
internally?
-Adrian
Adrian Görler
SAP AG
Pflichtangaben/Mandatory Disclosure
Statements: http://www.sap.com/company/legal/impressum.epx
SVN
main commit: bug#298985 - changing primary key from vector to object
https://bugs.eclipse.org/bugs/show_bug.cgi?id=298985
Changes:
-
Switching remain primary key methods from Vector to Object, (Vector is still
always used internally), ObjectBuilder, sessions, queries
-
Deprecated old public API that used Vector in IdentityMapAccessor, Session,
ReadObjectQuery, ReportQuery
-
Removed some dead code, added some @Overrides
Code
review: Gord
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev