Re: [eclipselink-dev] Please stop to hardcode concrete class instantiati

[Tom Ware <tom.ware@xxxxxxxxxx>]

Hi Sebastien,

  If you have some specific suggestions about how the code could be improved, 
please file a bug and include a patch with your suggestions.

-Tom

Sebastien Tardif wrote:
> Please stop to hardcode concrete class instantiation.
>
> In the code below, I don't see why you assume that SessionBroker should
> not be replaced by customer, using derived class, knowing that it is not
> really tested and coded well.
>
> Even if you believe some concrete class already have some hooks. You do
> not know all your customer needs. You should have as much hooks as
> possible. The basic start is to externalize resolution of the classes to
> instantiate.
>
> Thanks for your understanding.
>
>     protected SessionBroker buildSessionBrokerConfig(SessionBrokerConfig
> sessionBrokerConfig) {
>         SessionBroker sessionBroker = new SessionBroker();
> _______________________________________________
> eclipselink-dev mailing list
> eclipselink-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/eclipselink-dev