Re: [eclipselink-dev] bug-248780.patch

[Darani Yallapragada <Darani.Yallapragada@xxxxxxx>]

Hello Gordon,

I updated the patch with the changes suggested . Please do review it . ( Bug-248780 has been updated)

Thank You

Regards
Darani


Gordon Yorke wrote:

CacheImpl.java - createPKVector() -> no need to create local variables, just use method parameters.  Defining local variables could introduce errors and looks cluttered.
EntityManagerFactoryImpl.java -> make reference to cacheImpl 'protected'.  This is an EclipseLink coding pattern.

Otherwise this looks great.
--Gordon

Darani Yallapragada wrote:

Hello :

Fix for Bug#248780 is attached as "bug-248780.patch" file. Please do review this file .

Thank You

Regards
Darani

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev