Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[eclipselink-dev] Fix for bug 235484 - EclipseLink is holding onto old unit of work

The following fix for 235484 has been checked in, and was previously reviewed.

https://bugs.eclipse.org/235484
(A patch file has also been uploaded to this bug)

Description:

EclipseLink was holding onto UnitOfWork instances because Call objects due for caching were being placed into the DescriptorQueryManager's cache without being cloned and having their session reference nulled. This resulted in a memory leak.

Resolved problem by cloning calls to cache and setting their session to null before actually placing them in the cache. Additionally, they are then cloned when retrieved and set on an ExpressionQueryMechanism.

Testing adds another test: CachedUpdateCallsQueryClearTest (see uploaded patch)
to the QueryFrameworkTestSuite of FeatureTestModel.

Code Review:

Not Required (previously reviewed by Gordon Yorke, with input from James Sutherland. Additional fix input from Chris Delahunt and Andrei Ilitchev)

Testing:

LRG + New Test (A-OK)

--
Oracle Email Signature Logo
David Minsky | Senior Member of Technical Staff | (613) 288-4605
Oracle Server Technologies DDR
45 O'Connor Street, Suite 400, Ottawa, Ontario, Canada K1P 1A4

Back to the top