Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [eclipselink-dev] Using JUnit4 and Ant in EclipseLink ...

IMHO we should have common testing infrastructure in our core/foundation test package. I also feel its important that this testing infrastructure be truly common. If it is not shared between components then lets just keep it in the component that uses it. 

Basically I think we should use the structure we have and avoid premature refactoring.

Doug

-----Original Message-----
From: eclipselink-dev-bounces@xxxxxxxxxxx
[mailto:eclipselink-dev-bounces@xxxxxxxxxxx]On Behalf Of Tom Ware
Sent: Tuesday, October 02, 2007 9:21 AM
To: Dev mailing list for Eclipse Persistence Services
Subject: Re: [eclipselink-dev] Using JUnit4 and Ant in EclipseLink ...


Hi Mike,

  An alternate proposal to adding a "common" project is to consider the
"core.*" projects to be common.  Since everything will already depend on
them, why not have the common files in them?

-Tom
 

Mike Norman wrote:

> As part of the work to merge DBWS code into EclipseLink, some IPzilla
> CQ's (specifically
>  https://dev.eclipse.org/ipzilla/show_bug.cgi?id=1768 and 1755) were
> create to enable the use
> of the pb4 custom JUnit4 Runner and Ant task.  Not only are there DBWS
> tests that require
> this capability, but also new core feature tests for supporting
> non-JDBC arguments to StoredProcedures.
>
> This is the first time in EclipseLink that multiple components
> required some utility or library. To deal
> with this, I propose a new 'common' project - the directory structure
> would be as follows:
>
> ${eclipselink-svn-directory-root}
>     +---branches
>     \---trunk
>         |   about.txt
>         |   ...
>         |
>  (new)  +---common
>    -    |   \---eclipselink.common
>    -    |   |   |   .classpath
>    -    |   |   |   .project
>    -    |   |   |
>    -    |   |   +---lib
>    -    |   |   |       ant.jar                          (CQ 1768)
>    -    |   |   |       junit4-ext-pb4.jar               (CQ 1755)
>    -    |   |   |       ${other_commonly_used}.jar       (future CQ)
>    -    |   |   \---pb4
>  (new)  |   |       \--- ...
>  (old)  +---dbws
>         |   +---eclipselink.dbws
>         |   |   |   .classpath
>         |   |   |   .project
>         |   |   |
>         |   |   \---src
>         |   |       \---org
>         |   |           \---eclipse
>         |   |               \---persistence
>         |   |                   +---dbws
>         |   |                   |       ...
>         |    ...
>  (old)  +---foundation
>         |   +---eclipselink.core
>         |   |   |   .classpath
>         |   |   |   .project
>         |   |   |
>         |   |   \---src
>         |   |       \--- ...
>
>
> From a developer's view inside of an Eclipse IDE environment, the main
> projects (such as eclipselink.dbws, eclipselink.core and
> eclipselink.moxy) depend /apriori/ upon eclipselink.common. The other
> change will be relying upon version 4 of the JUnit library - this
> should not affect any code as the old JUnit 3.8.x APIs are preserved
> in JUnit4.
>
>
> --
> Oracle Email Signature Logo
> Mike Norman | Principal Software Designer | 613.288.4638
> Oracle Server Technologies | TopLink Product
> 45 O'Connor Street, Suite 400 | Ottawa, ON K1P 1A4 | (fax) 613.238.2818
>
>------------------------------------------------------------------------
>
>_______________________________________________
>eclipselink-dev mailing list
>eclipselink-dev@xxxxxxxxxxx
>https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
>
>
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

Back to the top