| Re: [eclipse.org-planning-council] eclipse.ini changes and restarts |
Hi Jonah,From our point of view the restart is what we want to see. Showing the dialog should only be considered if the restart wouldn't make it to the next release, or if noone can be found to work on the restart issue.Cheers,TitouanTitouan Vervack
R&D Engineer
Sigasi nv - Kerkstraat 108, 9050 Gentbrugge, Belgium
--------------------------------------------------------------------
On Wed, Sep 27, 2023 at 6:12 PM Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:Hi Titouan,I am left a little unsure how to proceed here. Let me ask you (and Sebastian) this in another way:Does the Planning Council, especially the members who highlighted the restart issue, want restart to work or are we satisfied in simply detecting when it may not work and displaying an error to the user asking them to manually shutdown and restart?I think the answer to that question does change the scope of the problem and solution somewhat. I would like to see Restart actually work even if eclipse.ini is changed. I have (occasionally) edited eclipse.ini to change Xmx and would have liked restart to pick up those changes.JonahOn Tue, 26 Sept 2023 at 09:31, Titouan Vervack <titouan.vervack@xxxxxxxxxx> wrote:Hi once again,As I was writing a response to the thread I realized that it wouldn't help us as we encounter issues while restarting. Mark explained it in detail here. As such, I don't feel like I'd be able to add anything to the issue you linked.Cheers,TitouanTitouan Vervack
R&D Engineer
Sigasi nv - Kerkstraat 108, 9050 Gentbrugge, Belgium
--------------------------------------------------------------------
On Tue, Sep 26, 2023 at 3:25 PM Titouan Vervack <titouan.vervack@xxxxxxxxxx> wrote:Hi Jonah, Sebastian,Sorry for the late response, I was on holiday.As I remember it Sebastian and I both had issues with restarting Eclipse after changes to its configuration. In our case specifically, this happens when users update to a new version of our product and this product contains a new JRE (JustJ).The issue you linked specifically doesn't cause issues to me, but I think Sebastian issue was similar.Sigasi's original issue was filed at JustJ by my colleague Mark Christiaens, but marked as a duplicate of your issue which refers to this equinox issue.I'll comment something on the thread as it would likely fix our issue.Cheers,TitouanTitouan Vervack
R&D Engineer
Sigasi nv - Kerkstraat 108, 9050 Gentbrugge, Belgium
--------------------------------------------------------------------
On Wed, Sep 20, 2023 at 8:22 PM Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:Hi folks,Was it you* who originally brought this issue https://github.com/eclipse-equinox/p2/issues/166 to planning council for inclusion as a dev effort?If so, can you comment your thoughts on the thread to make sure we end up with a reasonable solution. Someone has already put a proposal forward to Paul Buck's call for quotes so if we are going to change the solution entirely I want to resolve that quickly.* I can't remember who brought this forward initially, IIRC it was either @Titouan Vervack or @Ratz, Sebastian but I may be misremembering.ThanksJonah