Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse.org-committers] "Signed-off-by" is no longer required
  • From: "Sohn, Matthias" <matthias.sohn@xxxxxxx>
  • Date: Tue, 30 Mar 2021 21:22:38 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sap.com; dmarc=pass action=none header.from=sap.com; dkim=pass header.d=sap.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rbbq8UfsoyUF20CGvDE7TlN6DDaSURLGQhItADCprzM=; b=EBhoolm4bPbLPfcwWmWZJdeLyZwtvQpSXzZmwbpubAICo4+DCRSvHorsfMe09WxvF+p2dk18T0qONdtPFVE7FW1GyokrIUa0m6PgZkeH1xPcyoXzporNuo22zhHO4PR+6sFCNEkrmR7/e2sh7V7zGAff4MIt7O2UlAg2N3OtmqE2YYLh6BwgTU1GltrWvnTevV/7hm9zUrledaRchIJ8M/71EpYCwEymTp8XDwroIYY89q1Sv9wdkyod1kWNwMJoI3vNwzbG1rvHVdHDyTovDNYJAOScFmhpQJc99F6gHXviO8tbia/5xZf9o40shJz8I1tjMpy4ulSGGaLXDLYELA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nHGC8um2f9I5u98y0G/bxF0NaEZilgtK265isfLYZPscMS7hyeC7PIZ5zVax564pQcXJy2FAQ3+qkN8FlCt3x5Y978htJUhiSIekKDoJmIy2h4Ap5mBTwwbrSR1OsUFqYMRv6fE8ShjbRwKVKOuliUTCx+dJv3D8gdUabE7fyRxBtC+ZWGphndlUjL+BA/Qg13zpek86JBBfyhyapakaDsgIlYf0pPhqymXw9XeJ+dnFarY6peypn30hCP3T/sExjF4kdCUQJXWrtBxiddXMKC37Z9D4omvikpkgwzAXccUdvsLPayb6P4XhRPiRJbN8cqkSCuqUrjDsdm9Wvp/3cw==
  • Delivered-to: eclipse.org-committers@xxxxxxxxxxx
  • Ironport-sdr: O4HOAWo0YO/H7XZSsyWaI+B+U9UVhRZ/ve7QXn8F3WFpE+kS57e0P7H6l9XPjdHzbzG6d+F+sJ NU7yuJ6ZW7VBTnathgH7/6VPrNbqmmDqk/qsSMubmG6oP2MzyFy+P7/I3bQ2gg3uXmxU0ZJr9b oRwjbT4lb2GpuiQvaaQvo3aYZaBwwkmP2YfooCSqeVvIcgABAuJacqAkJ10k39vQN1FTq5pYtF 4ziPUbpYC+cB5P8JULAc1hEiPf+5/f6ldp4FVPdLGWa3Ci05Rfvrv/5rfUGqu5e76XMwNHM2LV XZueJhBPnemg0ewcI28kLeEl
  • List-archive: <https://www.eclipse.org/mailman/private/eclipse.org-committers/>
  • List-help: <mailto:eclipse.org-committers-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/eclipse.org-committers>, <mailto:eclipse.org-committers-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/eclipse.org-committers>, <mailto:eclipse.org-committers-request@eclipse.org?subject=unsubscribe>
  • Msip_labels: MSIP_Label_24989e87-1826-4595-8085-9c11e7f9468e_Enabled=true; MSIP_Label_24989e87-1826-4595-8085-9c11e7f9468e_SetDate=2021-03-30T20:12:08Z; MSIP_Label_24989e87-1826-4595-8085-9c11e7f9468e_Method=Standard; MSIP_Label_24989e87-1826-4595-8085-9c11e7f9468e_Name=Internal Use Only; MSIP_Label_24989e87-1826-4595-8085-9c11e7f9468e_SiteId=106bdeea-f616-4dfc-bc1d-6cbbf45e2011; MSIP_Label_24989e87-1826-4595-8085-9c11e7f9468e_ActionId=76c6fa9e-d615-4125-bc91-25f59db3be89; MSIP_Label_24989e87-1826-4595-8085-9c11e7f9468e_ContentBits=0
  • Thread-index: AQHXJWh0GGKpJ6RBjEestEnKzvf/f6qc0N6AgAAdKYCAAAkYAIAANTSA
  • Thread-topic: [eclipse.org-committers] "Signed-off-by" is no longer required
  • User-agent: Microsoft-MacOutlook/16.47.21031401

Every git commit contains the email address of the author and committer.

If you have a commit in your local clone you can show these details by using [1]:

 

$ git log –-format=fuller

 

On Github you can show it in the browser by appending .patch to a commit’s URL, e.g.

for this commit https://github.com/eclipse/jgit/commit/7672f25948004e4952e3ffd475da54fe5b44a2d0

https://github.com/eclipse/jgit/commit/7672f25948004e4952e3ffd475da54fe5b44a2d0.patch

 

For a change in Gerrit you can show it by clicking the commitId link above the list of changed files of the change detail screen

e.g. for https://git.eclipse.org/r/c/jgit/jgit/+/178422

 

Graphical user interface, text, application, email

Description automatically generated

 

which links to

https://git.eclipse.org/r/plugins/gitiles/jgit/jgit/+/7672f25948004e4952e3ffd475da54fe5b44a2d0

 

[1] https://git-scm.com/docs/git-log#_pretty_formats

 

From: "eclipse.org-committers" <eclipse.org-committers-bounces@xxxxxxxxxxx> on behalf of "Nanivadekar, Nikhil J via eclipse.org-committers" <eclipse.org-committers@xxxxxxxxxxx>
Reply to: "Nanivadekar, Nikhil J" <Nikhil.Nanivadekar@xxxxxxxxxxxxx>
Date: Tuesday, 30. March 2021 at 22:25
To: "eclipse.org-committers@xxxxxxxxxxx" <eclipse.org-committers@xxxxxxxxxxx>
Subject: Re: [eclipse.org-committers] "Signed-off-by" is no longer required

 

Hi Wayne, I think that is what I am trying to ask. If we remove Sign-off by, how am I supposed to correlate the commit to the email. For example, take this PR: https://github.com/eclipse/eclipse-collections/pull/1058

 

In the commit, the only way for me to know the email is by the sign-off. If I go by the user name, I don’t have the email address available.

 

When we create our Eclipse accounts, we have to put in our GitHub user name. Is it possible to have a ECA Validation Tool where we can check it against the GitHub user names as well?

 

Thanks,

Nikhil.

 

From: Wayne Beaton <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx>
Sent: Tuesday, March 30, 2021 2:40 PM
To: Nanivadekar, Nikhil J <Nikhil.Nanivadekar@xxxxxxxxxxxxx>
Cc: eclipse.org-committers@xxxxxxxxxxx
Subject: Re: [eclipse.org-committers] "Signed-off-by" is no longer required

 

The ECA Validation Tool still exists and is unchanged. If you can obtain the email address from the commit, you can determine whether or not we have a signed ECA associated with that email address.

 

 

 

HTH,

 

Wayne

 

On Tue, Mar 30, 2021 at 2:04 PM Nanivadekar, Nikhil J via eclipse.org-committers <eclipse.org-committers@xxxxxxxxxxx> wrote:

Hi Wayne,

This is great news and I am sure the entire contributor community will appreciate it!

Just one question, in case the webhook fails we had a way previously to verify the ECA using the ECA tool. Will we have a similar way of doing it in the new workflow?

 

I am asking this because as a committer, I will not know easily the email address associated with the ECA for the user and how do I validate that I am not accepting contributions incorrectly.

 

Thanks,

Nikhil.

 

From: eclipse.org-committers <eclipse.org-committers-bounces@xxxxxxxxxxx> On Behalf Of Wayne Beaton
Sent: Tuesday, March 30, 2021 7:49 AM
To: eclipse.org-committers@xxxxxxxxxxx
Subject: [eclipse.org-committers] "Signed-off-by" is no longer required

 

Greetings Eclipse Committers.

 

We're making a change to the contribution process. 

 

As you are aware, when you receive contributions from developers who are not project committers, we require those contributors to have signed the Eclipse Contributor Agreement (ECA) and for their contributions to to include a "Signed-off-by" footer with credentials that match those specified in the "Author" field in their commit comments. This combination serves an indication that the contributor understands and accepts the terms of the Developer Certificate of Origin (DCO) that is embedded in the ECA.

 

Effective March 30 at 1200h EDT, we are removing the "Signed-off-by" requirement. Instead, we believe that the combination of an author's email address in the "Author" field of a commit and having a valid ECA (or equivalent committer agreement) on file fulfill the DCO's "sign-off" requirement. That is, contributors must still sign the ECA, and must use the credentials associated with their Eclipse Foundation account in the "Author" field of all Git commits, but are no longer required to include a "Signed-off-by" footer in their commit comments. Note that it is not wrong for commits to include "Signed-off-by", it is just no longer required to meet our IP management goals.

 

The Eclipse Webmaster is rolling out updates to the repository hooks that had previously enforced this requirement and we are updating related documentation, including the Eclipse Foundation Project Handbook.

 

There is background and discussion on Bug 558653.

 

 

While I have your attention, a team of researchers would like your input.

 

Dear Eclipse committers,

 

I, together with a team of researchers, am trying to help improve software documentation and maintainability of open-source projects by providing automatic support of source code comments based on code review discussions as a final goal. We believe that code review tools store important discussions, and possible decisions, which can be useful for the project documentation. Thus, as a starting point, we would like to learn identifying relevant information from code review discussions such that tooling can be developed to improve software documentation and maintainability of open-source projects. If you are interested in talking about your experiences as an open-source reviewer then please schedule a meeting with us using YouCanBook.me here: https://tue-interview.youcanbook.me.

 

Kind regards and thanks in advance,

 

Nicole Novielli, University of Bari,

Fernando Castor, Federal University of Pernambuco,

Christoph Treude, University of Adelaide,

Alexander Serebrenik, Eindhoven University of Technology,

Felipe Ebert, Eindhoven University of Technology


Thanks,

 

Wayne

--

Wayne Beaton

Director of Open Source Projects | Eclipse Foundation


The information contained in this e-mail, and any attachment, is confidential and is intended solely for the use of the intended recipient. Access, copying or re-use of the e-mail or any attachment, or any information contained therein, by any other person is not authorized. If you are not the intended recipient please return the e-mail to the sender and delete it from your computer. Although we attempt to sweep e-mail and attachments for viruses, we do not guarantee that either are virus-free and accept no liability for any damage sustained as a result of viruses.

Please refer to https://disclaimer.bnymellon.com/eu.htm for certain disclosures relating to European legal entities. We take our data protection and privacy responsibilities seriously and our privacy notice explains how we collect, use and share personal information in the course of our business activities. It can be accessed at the privacy section of www.bnymellon.com.

_______________________________________________
eclipse.org-committers mailing list
eclipse.org-committers@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/eclipse.org-committers


 

--

Wayne Beaton

Director of Open Source Projects | Eclipse Foundation


The information contained in this e-mail, and any attachment, is confidential and is intended solely for the use of the intended recipient. Access, copying or re-use of the e-mail or any attachment, or any information contained therein, by any other person is not authorized. If you are not the intended recipient please return the e-mail to the sender and delete it from your computer. Although we attempt to sweep e-mail and attachments for viruses, we do not guarantee that either are virus-free and accept no liability for any damage sustained as a result of viruses.

Please refer to https://disclaimer.bnymellon.com/eu.htm for certain disclosures relating to European legal entities. We take our data protection and privacy responsibilities seriously and our privacy notice explains how we collect, use and share personal information in the course of our business activities. It can be accessed at the privacy section of www.bnymellon.com.


Back to the top