Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse.org-committers] Infra update: Gerrit, Github, Bugzilla, more. 
Markus is correct -- this is a Gerrit-only
and GitHub-ponly thing. We are trying to encourage projects to use Gerrit instead of pure Git, whether they use code review or not. 

In fact, every night I dream what we only use Gerrit for all our SCM needs:
Bug 452549 - Deprecate "pure Git" and use Gerrit for everything

    http://eclip.se/452549

Denis

On 06/19/2015 01:34 PM, Markus Keller wrote:

It's only a *Gerrit* plug-in, not a Git hook. To get the automatic
messages, you first have to create a Gerrit [1] review, and then merge
it via Gerrit. Either via the UI, or by pushing the commit with the
matching Change-Id to the Gerrit URL at git.eclipse.org:29418 (not to
git.eclipse.org/gitroot/...).

But I agree it would be nice to have for direct commits as well, so I
filed:
https://bugs.eclipse.org/470622Eclipse Genie should also write a comment
to Bugzilla when commit is pushed without a Gerrit review

[1] https://wiki.eclipse.org/Gerrit

Markus



From: Greg Wilkins <gregw@xxxxxxxxxxx>
To: Markus Keller/Zurich/IBM@IBMCH
Cc: eclipse.org-committers@xxxxxxxxxxx
Date: 2015-06-18 09:29
Subject: Re: [eclipse.org-committers] Infra update: Gerrit, Github,
Bugzilla, more.
Sent by: gregw@xxxxxxxxxxx
------------------------------------------------------------------------




Denis,

regardless of the pattern, this does not appear to be working for the
Jetty project.  See commit
_http://git.eclipse.org/c/jetty/org.eclipse.jetty.project.git/commit/?id=f9a3bdab2a45a0d87277dd65b6e1d28b409313a4_which
has not added anything to
_https://bugs.eclipse.org/bugs/show_bug.cgi?id=469384_

cheers


On 5 June 2015 at 23:39, Markus Keller <_markus_keller@xxxxxx.com_
<mailto:markus_keller@xxxxxxxxxx>> wrote:
[XXXXXX] doesn't work in many places and shouldn't be promoted:_
__Bug 421151_ <https://bugs.eclipse.org/421151>: Prefix [123456] should
link to bug 123456

The problem with too much flexibility is that it usually breaks in too
many places and in the end causes more pain than good. I don't think
anything other than "Bug XXXXXX" is really necessary.

Except maybe "Bug: XXXXXX" at the end of a Git comment, but that has its
issues as well:_
__Bug 465045_ <https://bugs.eclipse.org/465045>: Gerrit -> Bugzilla:
support "Bug: xxxxxx" at the end of the commit message too

Markus



From: Denis Roy <_denis.roy@eclipse.org_ <mailto:denis.roy@xxxxxxxxxxx>>
To: _eclipse.org-committers@eclipse.org_
<mailto:eclipse.org-committers@xxxxxxxxxxx>
Date: 2015-06-04 13:35
Subject: Re: [eclipse.org-committers] Infra update: Gerrit, Github,
Bugzilla, more.
Sent by: _eclipse.org-committers-bounces@eclipse.org_
<mailto:eclipse.org-committers-bounces@xxxxxxxxxxx>
------------------------------------------------------------------------




Replying to the list:

On 04/06/15 12:47 AM, Greg Wilkins wrote:

On 4 June 2015 at 04:38, Denis Roy <_denis.roy@eclipse.org_
<mailto:denis.roy@xxxxxxxxxxx>> wrote:
Bugzilla/GitHub
===============
You may have noticed that Gerrit and Github now actively "talk" to
Bugzilla. If a commit message contains "Bug: XXXXXX" a reference to the
Gerrit change/GitHub pull request will be created on Bugzilla.


But is there any chance of making that pattern a bit more flexible?


Greg,

I believe the patterns also match [XXXXXX] as well.  If not, please file
an enhancement request and we'll take a look.

Denis_______________________________________________
eclipse.org-committers mailing list_
__eclipse.org-committers@eclipse.org_
<mailto:eclipse.org-committers@xxxxxxxxxxx>
_https://dev.eclipse.org/mailman/listinfo/eclipse.org-committers_

IMPORTANT: Membership in this list is generated by processes internal to
the Eclipse Foundation.  To be permanently removed from this list, you
must contact _emo@eclipse.org_ <mailto:emo@xxxxxxxxxxx>to request removal.

_______________________________________________
eclipse.org-committers mailing list_
__eclipse.org-committers@eclipse.org_
<mailto:eclipse.org-committers@xxxxxxxxxxx>_
__https://dev.eclipse.org/mailman/listinfo/eclipse.org-committers_

IMPORTANT: Membership in this list is generated by processes internal to
the Eclipse Foundation.  To be permanently removed from this list, you
must contact _emo@eclipse.org_ <mailto:emo@xxxxxxxxxxx>to request removal.



--
Greg Wilkins <_gregw@webtide.com_ <mailto:gregw@xxxxxxxxxxx>> - /an
Intalio.com subsidiary/_
__http://eclipse.org/jetty_HTTP, SPDY, Websocket server and client that
scales_
__http://www.webtide.com_ <http://www.webtide.com/>advice and support
for jetty and cometd.


_______________________________________________
eclipse.org-committers mailing list
eclipse.org-committers@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse.org-committers

IMPORTANT: Membership in this list is generated by processes internal to the Eclipse Foundation.  To be permanently removed from this list, you must contact emo@xxxxxxxxxxx to request removal.

Back to the top