Re: [eclipse.org-architecture-council] Encourage projects to use JDT nul

["Sohn, Matthias" <matthias.sohn@xxxxxxx>]

JGit and EGit are using null analysis annotations since a while
https://git.eclipse.org/r/#/c/50569/
https://git.eclipse.org/r/50580/
and it already helped us to find a couple of NPEs

-Matthias


On 28.09.15 08:41, "eclipse.org-architecture-council-bounces@xxxxxxxxxxx
on behalf of Lars Vogel"
<eclipse.org-architecture-council-bounces@xxxxxxxxxxx on behalf of
lars.vogel@xxxxxxxxxxx> wrote:

>Hi Marcel,
>
>which project uses these annotation already?
>
>Before advicing all Eclipse project to use these annotations, I agree
>that we in Platform and JDT should start using them. (I assume that
>this is currently not the case, I might be wrong here). Our Bug for
>this is https://bugs.eclipse.org/bugs/show_bug.cgi?id=472631.
>
>Best regards, Lars
>
>On Mon, Sep 28, 2015 at 1:54 AM, Marcel Bruch
><marcel.bruch@xxxxxxxxxxxxxx> wrote:
>> Greetings Architecture Council,
>>
>> I spent some time on analyzing and visualizing user error reports.
>> One result of that analysis that strikes me most is that
>>NullPointerExceptions are the #1 root cause of all error reports.
>> It’s also ~4 times more popular than #2 on that list:
>>IllegalArgumentException (*).
>>
>> I wonder whether the architecture council should encourage projects to
>>tackle these errors, e.g., by enforcing or requesting all projects to
>>use JDT’s null analysis and @Nullable/@NonNull annotations on every
>>public API. Is that something the AC can drive and promote?
>>
>> As a second means, the EPP Committer package may enable JDT’s null
>>analysis by default to get that started.
>>
>> It would also need a few popular projects to lead the way. I’m thinking
>>of Platform/Platform UI and JDT but… of course… it’s additional work for
>>them… But I hope this pays out for Eclipse as a whole rather soon.
>> I can also imagine to ask all projects that participate in Neon to work
>>towards this goal.
>>
>> What do others think?
>>
>>
>> Cheers,
>> Marcel
>>
>>
>>
>> (*) Please visit [1] to confirm that observation (Note:
>>org.eclipse.epp.internal.logging.StandInException and
>>org.eclipse.recommenders.internal.StandInException are not counted.
>> [1] 
>>https://dev.eclipse.org/recommenders/committers/dashboard/#/dashboard/Pro
>>blems
>> _______________________________________________
>> eclipse.org-architecture-council mailing list
>> eclipse.org-architecture-council@xxxxxxxxxxx
>> 
>>https://dev.eclipse.org/mailman/listinfo/eclipse.org-architecture-council
>>
>> IMPORTANT: Membership in this list is generated by processes internal
>>to the Eclipse Foundation.  To be permanently removed from this list,
>>you must contact emo@xxxxxxxxxxx to request removal.
>
>
>
>-- 
>Eclipse Platform UI and e4 project co-lead
>CEO vogella GmbH
>
>Haindaalwisch 17a, 22395 Hamburg
>Amtsgericht Hamburg: HRB 127058
>Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
>USt-IdNr.: DE284122352
>Fax (032) 221739404, Email: lars.vogel@xxxxxxxxxxx, Web:
>http://www.vogella.com
>_______________________________________________
>eclipse.org-architecture-council mailing list
>eclipse.org-architecture-council@xxxxxxxxxxx
>https://dev.eclipse.org/mailman/listinfo/eclipse.org-architecture-council
>
>IMPORTANT: Membership in this list is generated by processes internal to
>the Eclipse Foundation.  To be permanently removed from this list, you
>must contact emo@xxxxxxxxxxx to request removal.