Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[eclipse.org-architecture-council] IP / Provenience problem ? When multiple contributors collaborate on Gerrit

Hi all,

 

I noticed some peculiar behavior of Gerrit yesterday, which might be an IP / Provenience issue.

 

Consider this Gerrit change:

https://git.eclipse.org/r/#/c/13740/

 

Patch set 1 is a commit from Sergey Prigogin, which was cherry-picked for a backport.

Patch sets 2 and 3 are later modifications by Caroline Rieder (re-adding a file).

Essentially, Caroline authored zero code, she just performed the backport.

 

Yet the final commit to git only shows Caroline Rieder as author of the change:

https://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?h=cdt_8_1&id=e320522e706e522c0b29f2b7d8f771cf8b0933ac

 

It looks like íf multiple contributors collaborate on a change in Gerrit, creating multiple patch sets, the final commit into Eclipse git is done with a single commit thus only the last contributor gets the credit . AFAIK Egit is a project where Gerrit changes tend to be open for a long time, with multiple contributors collaborating potentially.

 

Are we aware whether Gerrit is supposed to work that way, or whether there’s an alternative mode recording the history of all patch sets as a branch / merge ?

 

Related to the “automated CLA” change that’s upcoming, it seems problematic to me when the original authors of a change are no longer recorded in the Eclipse git history.

 

What do others think – particularly the IP / Git / Gerrit experts ?

 

Thanks,

Martin

--

Martin Oberhuber, SMTS / Product Architect – Development Tools, Wind River

direct +43.662.457915.85  fax +43.662.457915.6

 


Back to the top