Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[eclipse-pmc] JDT wants to change field type in org.eclipse.jdt.internal.core.builder.State

Hi all,

We want merge patch https://git.eclipse.org/r/#/c/162792/ in JDT that changes type of a "typeLocators" field in internal, non-API org.eclipse.jdt.internal.core.builder.State class.

Please note, this class was never API, so any uses of outside JDT were illegal anyway.

We know that Xtext uses this field and it will need a patch to fix the type change, see https://github.com/eclipse/xtext-eclipse/issues/1450.

We just want to ask for opinions if we can proceed with the patch for M3 or not.

The reason for patch is to improve build performance for big projects, where current code simply doesn't scale. For example, time to recompile some 20000 files after change will drop from 6+ minutes to < 30 seconds. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=563030.

Please comment either on bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=563030 or on patch.


Kind regards,
Andrey Loskutov

Спасение утопающих - дело рук самих утопающих

https://www.eclipse.org/user/aloskutov



Back to the top