Re: [eclipse-pmc] Change #119156

["Daniel Megert" <daniel_megert@xxxxxxxxxx>]

Also -1. I agree
with Tom's assessment in the Gerrit change.

Dani



From:
       "Thomas
Watson" <tjwatson@xxxxxxxxxx>
To:
       eclipse-pmc@xxxxxxxxxxx
Date:
       09.05.2018
14:34
Subject:
       Re:
[eclipse-pmc] Change #119156
Sent
by:        eclipse-pmc-bounces@xxxxxxxxxxx

---

-1 from me.
 
I put some comments
in the review.  I could have missed something because I did a quick
review.  But the fix looks like it introduces a different kind of
deadlock.  Also the method in question could be made package private,
correct?

Tom
 
 
 
----- Original message
-----
From: Aleksandar Kurtakov <akurtako@xxxxxxxxxx>
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
To: eclipse-pmc@xxxxxxxxxxx
Cc:
Subject: Re: [eclipse-pmc] Change #119156
Date: Wed, May 9, 2018 7:18 AM
  
  
  
On Wed, May 9, 2018
at 1:58 PM, Karsten Thoms <karsten.thoms@xxxxxxxxx>
wrote: 
Dear PMC, 
 
I reviewed and merged
today change#119156(Bug#532273)
and made 2 important mistakes:
- The patch adds an
API method. In my initial review I commented that PMC approval is needed
and thought Conrad would request this then, but it did not happen. However,
he addressed the other comments and submitted a change that looks good
to me.
- It is M7 quiet week,
I did not have this in mind. I thought it was time to review last changes
for M7.
 
Apologies for those
mistakes. How to proceed now? Can this change be approved or shall it be
reverted?
 
As it's fixing race
condition I think we can approve an exception. But better javadoc for the
new method is due.
Anyone disagrees?
 
 
Conrad covered his
change by additional tests in DifferentRealmsBindingTest.
 
Kind regards,
~Karsten

_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc

-- 
Alexander Kurtakov
Red Hat Eclipse Team
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
 

_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc