Re: [eclipse-pmc] PMC approval needed for patch https://git.eclipse.org/

[Lars Vogel <lars.vogel@xxxxxxxxxxx>]

> so this needs to be reviewed with special care.

As I pointed out, Conrad, the committer who did the review, has a very
deep understanding of data binding.

On Tue, Mar 20, 2018 at 9:18 AM, Tom Schindl
<tom.schindl@xxxxxxxxxxxxxxx> wrote:
> On 19.03.18 22:35, Lars Vogel wrote:
>> +1 from my side (as I suggest to Conrad to ask the PMC for
>> permission). I know Conrad and he has a very deep understanding of DB
>> and I trust his judgment.
>>
>> Also, the API relevant change is minimal with only two (small) classes.
>
> Really? I count a whole lot of API changes because generics have been
> added. When you generify an API you have ONLY one chance to get it
> right, so this needs to be reviewed with special care.
>
> Having said that, I have no time to review this stuff.
>
> Tom
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc



-- 
Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com