Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] Request for splitting out a PDE spy into a separate bundle to make it consumable in RCP

Thanks Lars,

+1 for refactoring into a bundle from my POV. Breaking unnecessary dependencies is always a good thing. Would it make sense maintaining backward compatibility by re-exporting the new bundle from the old one .. or should we clean this up ?

Thanks,
Martin
--
Martin Oberhuber, SMTS / Product Owner – Development Tools, Wind River

On 05/04/17 14:27, "eclipse-pmc-bounces@xxxxxxxxxxx on behalf of Lars Vogel" <eclipse-pmc-bounces@xxxxxxxxxxx on behalf of lars.vogel@xxxxxxxxxxx> wrote:

    > If it is technically possible to break dependencies onto PDE, this spy can live as a separate bundle in the PDE repository. Right ?
    
    Yes, and that is exactly what I'm asking here. I would like to move it
    to a new bundle in the PDE repository. For M7 any new bundle needs PMC
    approval.
    
    Best regards, Lars
    
    On Wed, Apr 5, 2017 at 11:47 AM, Oberhuber, Martin
    <Martin.Oberhuber@xxxxxxxxxxxxx> wrote:
    > Hi Lars,
    >
    > I don’t quite understand.
    >
    > If it is technically possible to break dependencies onto PDE, this spy can live as a separate bundle in the PDE repository. Right ? The PDE repository isn’t that big and doesn’t have dependencies other than JDT … so just having to clone one extra git repo shouldn’t cause issues.
    >
    > Am I missing a point ?
    >
    > Thanks,
    > Martin
    > --
    > Martin Oberhuber, SMTS / Product Owner – Development Tools, Wind River
    >
    > On 04/04/17 21:30, "eclipse-pmc-bounces@xxxxxxxxxxx on behalf of Lars Vogel" <eclipse-pmc-bounces@xxxxxxxxxxx on behalf of lars.vogel@xxxxxxxxxxx> wrote:
    >
    >     > Anyway, I'm not strongly against moving it inside PDE if the other PMC
    >     > members agree.
    >
    >     Any opinion from the other PMC members? Again, this change includes no
    >     functional change, no API. It will only make this spy available for
    >     RCP customers without pulling PDE as dependency.
    >
    >     >
    >     > Dani
    >     > From:        Lars Vogel <lars.vogel@xxxxxxxxxxx>
    >     > To:        eclipse-pmc@xxxxxxxxxxx
    >     > Date:        31.03.2017 12:35
    >     > Subject:        Re: [eclipse-pmc] Request for splitting out a PDE spy into a
    >     > separate bundle to make it consumable in RCP
    >     >
    >     > Sent by:        eclipse-pmc-bounces@xxxxxxxxxxx
    >     > ________________________________
    >     >
    >     >
    >     >
    >     > Because it is a tool for plug-in and RCP development. I prefer to have
    >     > such tools in PDE which IMHO is the logical place for them.
    >     >
    >     > Also the PMC approved a while ago to move the e4 spies to PDE and it
    >     > think this spies will fit well into them. (Note: the move has never
    >     > started due to capacity issues on the e4 side, but is still planned).
    >     >
    >     > Best regards, Lars
    >     >
    >     > On Fri, Mar 31, 2017 at 12:25 PM, Daniel Megert
    >     > <daniel_megert@xxxxxxxxxx> wrote:
    >     >> If the goal is to make it independent of PDE, why then not move it to the
    >     >> platform.ui repository? With the proposed solution developers that want to
    >     >> work on the spy still have to clone the whole PDE repository, just for
    >     >> that
    >     >> single bundle.
    >     >>
    >     >> Dani
    >     >>
    >     >>
    >     >>
    >     >> From:        Lars Vogel <lars.vogel@xxxxxxxxxxx>
    >     >> To:        eclipse-pmc@xxxxxxxxxxx
    >     >> Date:        31.03.2017 12:19
    >     >> Subject:        [eclipse-pmc] Request for splitting out a PDE spy into a
    >     >> separate bundle to make it consumable in RCP
    >     >> Sent by:        eclipse-pmc-bounces@xxxxxxxxxxx
    >     >> ________________________________
    >     >>
    >     >>
    >     >>
    >     >> Hi,
    >     >>
    >     >> I request permission to move the existing PDE layout spy to a separate
    >     >> bundle. This will make the layout spy consumable without pulling in
    >     >> PDE and its dependencies into the RCP application.
    >     >>
    >     >> No functionality is altered by this move. No API is created by this
    >     >> change.
    >     >>
    >     >> See Bug 503393 - Move SWT layout spy to separate plug-in to remove PDE
    >     >> dependency for RCP apps
    >     >>
    >     >> Best regards, Lars
    >     >> --
    >     >> Eclipse Platform UI and e4 project co-lead
    >     >> CEO vogella GmbH
    >     >>
    >     >> Haindaalwisch 17a, 22395 Hamburg
    >     >> Amtsgericht Hamburg: HRB 127058
    >     >> Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
    >     >> USt-IdNr.: DE284122352
    >     >> Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web:
    >     >> http://www.vogella.com
    >     >>
    >     >> _______________________________________________
    >     >> eclipse-pmc mailing list
    >     >> eclipse-pmc@xxxxxxxxxxx
    >     >> To change your delivery options, retrieve your password, or unsubscribe
    >     >> from
    >     >> this list, visit
    >     >> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
    >     >>
    >     >>
    >     >>
    >     >> _______________________________________________
    >     >> eclipse-pmc mailing list
    >     >> eclipse-pmc@xxxxxxxxxxx
    >     >> To change your delivery options, retrieve your password, or unsubscribe
    >     >> from
    >     >> this list, visit
    >     >> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
    >     >
    >     >
    >     >
    >     > --
    >     > Eclipse Platform UI and e4 project co-lead
    >     > CEO vogella GmbH
    >     >
    >     > Haindaalwisch 17a, 22395 Hamburg
    >     > Amtsgericht Hamburg: HRB 127058
    >     > Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
    >     > USt-IdNr.: DE284122352
    >     > Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web:
    >     > http://www.vogella.com
    >     > _______________________________________________
    >     > eclipse-pmc mailing list
    >     > eclipse-pmc@xxxxxxxxxxx
    >     > To change your delivery options, retrieve your password, or unsubscribe from
    >     > this list, visit
    >     > https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
    >     >
    >     >
    >     >
    >     > _______________________________________________
    >     > eclipse-pmc mailing list
    >     > eclipse-pmc@xxxxxxxxxxx
    >     > To change your delivery options, retrieve your password, or unsubscribe from
    >     > this list, visit
    >     > https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
    >
    >
    >
    >     --
    >     Eclipse Platform UI and e4 project co-lead
    >     CEO vogella GmbH
    >
    >     Haindaalwisch 17a, 22395 Hamburg
    >     Amtsgericht Hamburg: HRB 127058
    >     Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
    >     USt-IdNr.: DE284122352
    >     Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
    >     _______________________________________________
    >     eclipse-pmc mailing list
    >     eclipse-pmc@xxxxxxxxxxx
    >     To change your delivery options, retrieve your password, or unsubscribe from this list, visit
    >     https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
    >
    > _______________________________________________
    > eclipse-pmc mailing list
    > eclipse-pmc@xxxxxxxxxxx
    > To change your delivery options, retrieve your password, or unsubscribe from this list, visit
    > https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
    
    
    
    -- 
    Eclipse Platform UI and e4 project co-lead
    CEO vogella GmbH
    
    Haindaalwisch 17a, 22395 Hamburg
    Amtsgericht Hamburg: HRB 127058
    Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
    USt-IdNr.: DE284122352
    Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
    _______________________________________________
    eclipse-pmc mailing list
    eclipse-pmc@xxxxxxxxxxx
    To change your delivery options, retrieve your password, or unsubscribe from this list, visit
    https://dev.eclipse.org/mailman/listinfo/eclipse-pmc


Back to the top