Re: [eclipse-pmc] Approval for Bug 510728 API changes in styling of tree

["Daniel Megert" <daniel_megert@xxxxxxxxxx>]

> My vote is
+1 under the precondition that the SWT team is happy with the change.

Same here:

+1 if SWT accepts the fix, -1 otherwise.

Dani



From:      
 Lars Vogel <lars.vogel@xxxxxxxxxxx>
To:      
 eclipse-pmc@xxxxxxxxxxx
Date:      
 29.03.2017 15:25
Subject:    
   [eclipse-pmc]
Approval for Bug 510728 API changes in styling of tree header background
and foreground color
Sent by:    
   eclipse-pmc-bounces@xxxxxxxxxxx

---

Dear PMC colleagues,

On behave of the SWT team I would like to ask PMC permissions for "Bug
510728 - Allow styling of tree headers foreground and background
color".

The implementation is almost identical to the change for table headers
which we did in M7. Hence the risk should be low. If we do not deliver
it we have an inconsistency in our UI (table headers vs tree headers).

This fix is needed Platform UI need to provide the CSS styling
implementation based on the SWT change and the css for the dark theme.
We really would like to have this in for M7 so that we can deliver
(finally) a (relative) decent dark theme. Also several of our RCP
customers are awaiting this change.

This change needs still the final code review by the SWT team.
But as it is almost the same as the already integrated change for
table headers, I expect no surprises in this code review. And I would
like to avoid missing M7 due to missing PMC approval.

My vote is +1 under the precondition that the SWT team is happy with the
change.

Best regards, Lars

-- 
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc