Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] Request for approval to deprecateorg.eclipse.ui.cocoa.fullscreenWindow command for 4.6

Brian, the deprecation was approved yesterday by the PMC

On Sat, May 21, 2016 at 8:55 AM, Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:
> Hi Brian
>
> Usually I would not approve deprecating things so late in the game, since it
> can cause new warnings in our clients code. However, this is not the case
> here, since the deprecation is communicated via documentation and mailing
> lists.
>
> I'm in favor of doing it. Let's see what other PMC members think.
>
> The removal has to be done later as per
> https://wiki.eclipse.org/Eclipse/API_Central/Deprecation_Policy#Removal_of_Deprecated_API.
>
> Dani
>
>
>
> From:        Brian de Alwis <briandealwis@xxxxxxxxx>
> To:        eclipse-pmc@xxxxxxxxxxx
> Date:        20.05.2016 20:05
> Subject:        [eclipse-pmc] Request for approval to deprecate
> org.eclipse.ui.cocoa.fullscreenWindow command for 4.6
> Sent by:        eclipse-pmc-bounces@xxxxxxxxxxx
> ________________________________
>
>
>
> In 4.2 we introduced a OS X-specific command to toggle full-screen called
> “org.eclipse.ui.cocoa.fullscreenWindow” (bug 376394), bound to
> Ctrl-Command-F.  In 4.6 we introduced a cross-platform command to toggle
> full-screen called “ org.eclipse.ui.window.fullscreenmode” (bugs 489087,
> 491572).  As a result, we have two “Toggle Full Screen” commands on OS X,
> and both appear in the Quick Access.  Both are functional, but it would be
> nice to consolidate to one command.
>
> I would like to propose that we deprecate the OS X-specific command for 4.6
> (bug  493930) and remove it in 4.7 (bug 493932).  Our documentation for
> deprecating and removing API doesn’t talk about commands, and the commands
> infrastructure doesn’t have any ability to mark a command as being
> deprecated.  One approach is:
>
> Add a note to the porting guide
> Post to cross-project-issues-dev and eclipse-dev
>
>
> As the OS X specific command had a keybinding, it’s unlikely that it has
> been referenced by other applications.
>
> Removing the command is a bit trickier as it was defined as an E4-level
> command and will be present in saved workbench.xmi files.  To remove the
> command:
>
> Make “org.eclipse.ui.window.fullscreenmode” an E4-level command
> Cause the CocoaUIProcessor, which runs on startup and previously ensured
> that “org.eclipse.ui.cocoa.fullscreenWindow” was created, to find and change
> all references to the “org.eclipse.ui.cocoa.fullscreenWindow” command to the
> “org.eclipse.ui.window.fullscreenmode” command.
>
>
>
> An alternative might be to defer the deprecation to 4.7 and removal to 4.8,
> and add the ability to mark and report a command as being deprecated for
> 4.7.
>
> Brian._______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
>
>
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc



-- 
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com


Back to the top