Re: [eclipse-pmc] Request API exemption for Bug 491556 - [Welcome] Provi

[Lars Vogel <lars.vogel@xxxxxxxxxxx>]

Hi Brian,

I tried to dig up old information but I think my memory was wrong.

I withdraw any concerns my other email might have indicated. The
current rule is that we have to wait three days for the PMC members to
express concerns.

To make this clear: I have not concerns (anymore).

Best regards, Lars

On Thu, Apr 14, 2016 at 6:42 PM, Brian de Alwis <briandealwis@xxxxxxxxx> wrote:
> Hi Lars.
>
> I’ve never heard of such an extension mechanism!  But I don’t think it can
> be used here as these files are looked up from the bundle, and not through
> Core Resources, but it would be interesting to use as a template so at least
> there’s consistent behaviour.
>
> Brian.
>
> On 14-Apr-2016, at 12:37 PM, Lars Vogel <lars.vogel@xxxxxxxxxxx> wrote:
>
> Hi Brian,
>
> Did you check with Eclipse resource committers? IIRC resources has a similar
> lookup for custom images loading which can be used to override for example
> images specified via extensions.
>
> It is really long since I looked into this, so I might be wrong. I think
> John Arthorne gave that explanation somewhere in the past, unfortunately I
> cannot remember where.
>
> Best regards, Lars
>
> Am 14.04.2016 4:35 nachm. schrieb "Brian de Alwis" <briandealwis@xxxxxxxxx>:
>
> I’d like to request an API exemption for M7 for the following change:
>
> Bug 491556 - [Welcome] Provide theme-specific mechanism to influence path
> resolution
> https://git.eclipse.org/r/70362
>
> This change adds a new theme property for Welcome/Intro themes called
> “filePrefix” used to resolve theme-dependent variants of images that are
> referenced by the theme.
>
> We need this functionality for the new Solstice theme (bug 466370). Unlike
> the previous themes (circles, slate, and mesh), the Solstice theme has a
> dark background where the product logos are shown.  The Eclipse logo is
> effectively invisible in this theme.
>
> The filePrefix causes the Intro code to first attempt to resolve images with
> the given prefix and then fallback to the path as-is.  This prefixing only
> happens for files specified as product-properties, such as the branding
> logo.  For example, the Solstice theme defines (simplified; full details in
> patch):
>
> <theme id=“org.eclipse.ui.intro.universal.solstice">
>         <property name=“filePrefix” value=“solstice-“ />
> …
> </theme>
>
> The Platform and SDK products specify their branding logo using a product
> property like:
>
>  <property name=“introBrandingImage” value=“product:intro-eclipse.png” />
>
> When resolving the introBrandingImage, the code will now first try resolving
> ’solstice-intro-eclipse.png’ from the product bundle.  If not found, it will
> fallback to ‘intro-eclipse.png’.  If a directory is specified (e.g.,
> ‘product:logos/eclipse.png’) then the prefix is applied to the file portion
> (‘logos/solstice-eclipse.png’).
>
> Without this change, product definitions have to explicitly reference a more
> Solstice-friendly logo.  But then the other themes don’t look as intended.
> [Though to be honest, I think they all look better with the white logo.]
>
>
> SCREENSHOT
>
> Solstice with the current logo (purple lettering):
>
> <Without Solstice-friendly logo.PNG>
>
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
>
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
>
>
>
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc



-- 
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com