Re: [eclipse-pmc] Fix for 4.3.2 RC4

[Mike Wilson <Mike_Wilson@xxxxxxxxxx>]

Code seems safe to me.

+1.

McQ.


Paul Webster ---02/11/2014 12:54:00---Hi, Platform UI would like to contribute the following fix to 4.3.2 RC4:

From: Paul Webster <pwebster@xxxxxxxxxxxxxxxxxxx>
To: Eclipse PMC <eclipse-pmc@xxxxxxxxxxx>, "Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx>
Date: 02/11/2014 12:54
Subject: [eclipse-pmc] Fix for 4.3.2 RC4
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx

---

Hi,

Platform UI would like to contribute the following fix to 4.3.2 RC4:
Bug 427924 - [Contexts] NullPointerException in WorkbenchPage.getViewStack()

This bug strike some people consistently, breaking their debug keybindings.  It's a combination of workspace+install, so even switching workspaces brings only temporary relief.

Risk:  very low.

This is an NPE guard in a method that returns an array built from a list, so callers of the method won't be surprised by any unexpected return results.

I've already talked to Dani, he's agreed to +1 it (as long as it fixes the problem :-)

PW

-- 
Paul Webster
Hi floor.  Make me a sammich! - GIR _______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc