Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] Request to correct Ant/External tool bundle version numbers


I think the API tools can usefully check for the case where API changes did occur, but the version number was not incremented. This is the most common mistake that is extremely useful to have a tool help with. I don't think it can properly assess the case where the version number incremented but there was no API change. As we have always specified in the versioning guidelines, API changes aren't the *only* reason for incrementing a plug-in's minor version:

http://wiki.eclipse.org/Version_Numbering#When_to_change_the_minor_segment

Looking at a diff of org.eclipse.ant.core between 3.3.2 and HEAD today, it looks like only two lines of code changed in one method. So it does appear that the version number was incremented incorrectly in this case, but the API tools can't really help with this decision.

John



Olivier Thomann/Ottawa/IBM@IBMCA
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx

05/13/2008 09:24 AM

Please respond to
eclipse-pmc@xxxxxxxxxxx

To
eclipse-pmc@xxxxxxxxxxx
cc
Subject
Re: [eclipse-pmc] Request to correct Ant/External tool bundle version        numbers





This means that the check made by API tools on the minor version is
useless and should be removed.




Philippe P Mulet <philippe_mulet@xxxxxxxxxx>
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
2008-05-13 08:58
Please respond to
eclipse-pmc@xxxxxxxxxxx


To
eclipse-pmc@xxxxxxxxxxx
cc

Subject
Re: [eclipse-pmc] Request to correct Ant/External tool bundle version
numbers







Given the reactions in the community, I would vote to live with the few
inconsistencies, and revert to plug-in version numbers from M6.



Darin Wright <Darin_Wright@xxxxxxxxxx>
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
05/12/2008 04:57 PM

Please respond to
eclipse-pmc@xxxxxxxxxxx


To
eclipse-pmc@xxxxxxxxxxx
cc

Subject
[eclipse-pmc] Request to correct Ant/External tool bundle version numbers








GOALS/BENEFITS:
Correct the version of Ant and External tools plug-ins in the 3.4 release.

ASSOCIATED BUGS:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=220385
https://bugs.eclipse.org/bugs/show_bug.cgi?id=231305

RISKS:
Bundles that have incremented their version requirement on these bundles
will be broken.

PERFORMANCE IMPACT:
none

DESCRIPTION:
The following bundles incorrectly had their minor version numbers
incremented during the 3.4 release, when in fact there were no API
additions. Propose to correct the bundle versions to reflect this.

org.eclipse.ant.core:           should be 3.1.300 (and was incorrectly
3.2.0)
org.eclipse.ant.ui:             should be 3.2.300 (and was incorrectly
3.3.0)
org.eclipse.ui.externaltools:   should be 3.1.300 (and was incorrectly
3.2.0)

NOTES:
There are other bundles in the same situation (for example, I know of
org.eclipse.pde.core), so we should decide on how we are going to treat
this problem in general for the 3.4 release.


Darin Wright

_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc



Sauf indication contraire ci-dessus:/ Unless stated otherwise above:
Compagnie IBM France
Siège Social : Tour Descartes, 2, avenue Gambetta, La Défense 5, 92400
Courbevoie
RCS Nanterre 552 118 465
Forme Sociale : S.A.S.
Capital Social : 542.737.118 ?
SIREN/SIRET : 552 118 465 02430
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc


_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc


Back to the top