Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] Request for limiting access scope for a method in TextMergeViewer

Is the reason why there are leaks because there *are* people using this API
(incorrectly) now?

McQ.



                                                                           
             Tomasz Zarna                                                  
             <TomaszZarna@pl.i                                             
             bm.com>                                                    To 
             Sent by:                  eclipse-pmc@xxxxxxxxxxx             
             eclipse-pmc-bounc                                          cc 
             es@xxxxxxxxxxx            Michael Valenta/Ottawa/IBM@IBMCA    
                                                                   Subject 
                                       [eclipse-pmc] Request for limiting  
             04/17/08 12:35 PM         access scope for a method in        
                                       TextMergeViewer                     
                                                                           
             Please respond to                                             
             eclipse-pmc@eclip                                             
                  se.org                                                   
                                                                           
                                                                           





To fix the leak in the
org.eclipse.compare.contentmergeviewer.TextMergeViewer.isCurrentDiff(Diff)
method limiting its access scope from public to private is required. The
org.eclipse.compare.contentmergeviewer.TextMergeViewer class is API so I
need PMC persmission to proceed.

GOALS/BENEFITS:

No leak and no warning from the API Tooling.

CORRESPONDING BUG(S):

https://bugs.eclipse.org/bugs/show_bug.cgi?id=227585

RISKS:

No risk

PERFORMANCE IMPACTS:

No performance impact
--
Tomasz Zarna

_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc




Back to the top