Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ecf-dev] rosgi and asm in Luna

Hi Cristiano,

Yes...thanks.  Since I'm not absolutely sure what rosgi actually uses from asm 3.3 (currently) I don't know if the 5.0.1 missing pieces would be a problem.  I suspect not, actually, but again I'm not sure.  That's more a question for those more familiar with rosgi internals...i.e. Jan or Markus.

But FWIW...ECF already has piggyback CQ setup/approved for asm 5.0.1 [1].

Scott

[1] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=8123


On 4/18/2014 8:51 AM, Cristiano Gavião wrote:
Scott,

to complement...  a email was sent this week to cross-project-issues list about the ASM 5 problem in Orbit.
I'm reproducing it below...

2. org.objectweb.asm

This probably effects far fewer people, but is a much larger, and "breaking" change. Not "API breakage", no change to your code, but to your MANIFEST.MF file. We recently found out (thanks Mat) that the "third party" project (objectweb ASM) had (last release, which we skipped) started to "break up" their one jar into 6 smaller ones and, even, provide their own OSGi bundles. So the "5.0.1" version that has been in Orbit for a month or so did not follow their pattern, and in fact, could conflict with it "in the wild", so we felt we had to change and follow their pattern -- just to be good citizens, if nothing else ... but in some cases, will allow tiny fraction of savings in size. Unfortunately, they choose to leave "org.objectweb.asm" as one of the smaller bundles (so we could not use that as an "umbrella bundle", reexporting the smaller pieces) so anyone who "requires" that specific bundle, as some have for years and years, will likely get compile errors on the new "5.0.1" due to missing classes, and you will have to add which ever of additional org.objectweb.asm.xxxxx bundles you need. See the Orbit download page for complete list of 6, and/or see Bug 431820 for the discussion and resolution of the issue.

Cristiano

On 13-04-2014 10:19, slewis@xxxxxxxxxxxxx wrote:
On 4/13/2014 1:57 AM, Markus Alexander Kuppe wrote:
<stuff deleted>


Hi Scott,

is there any technical reason to upgrade to asm 5.x.x expect that Luna
comes with it?
I don't know precisely what rosgi uses asm for...so I don't know.     My
understanding is that asm < 5.0 doesn't handle java8 byte code...so that
could be a problem for using rosgi for java8-based remote services.  
Perhaps not, but you and/or Jan will have to answer that.

If no - unless asm is a singleton bundle - we can easily
distribute asm 3.x.x with ECF and let Luna ship whatever it wants to.
That's true...and in fact we already do this (version 3.3.1 of asm).  
This installs fine into Luna (no singleton).   However,  in running tests
of the tutorial example product configs...the presence of two versions of
the asm dependency seems to be resulting in the wrong version being
selected at runtime.   This isn't fatal (the correct one can be selected
in the generated launch config)...but it's inconvienient for new users who
are using the tutorial to learn about remote services/ECF/rosgi.

Scott




_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev



_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev


Back to the top