[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ecf-dev] Gerrit

At the time, I tried to get a patch into gerrit. I kept screwing up the commits and they had to be undone by one of the team members. I remember spending more time fighting the system than I did coding.  It was quite embarrassing [1].

All this was probably due to an early version of gerrit and an early version of git.

When I look back to the history [1] it does contain a nice amount of information.

I am +1 for trying it again.   


[1]  https://git.eclipse.org/r/#/c/269/ 

On Tue, Jul 31, 2012 at 5:14 PM, Scott Lewis <slewis@xxxxxxxxxxxxx> wrote:
Hi Wim,

Would you briefly describe your experiences with using gerrit for the git project?

My hope was that *particularly* for non-committer contributions, that gerrit could make things easier/quicker/more efficient than reviewing attachments to bugs.  If it doesn't actually accomplish that, however...or costs a lot to do that...then I don't want to add process.

Thanks,

Scott



On 7/31/2012 1:19 AM, Wim Jongman wrote:

Sure.

I am a bit concerned about how effective it will be given our scarce resources. It was quite complicated to me when I tried to contribute to the git project. Hence my reservations.

Anyway, I am happy to give it another try. I will try to free some time to investigate.

Met vriendelijke groet,

Wim

On 30 jul. 2012, at 23:31, Scott Lewis <slewis@xxxxxxxxxxxxx> wrote:

Hi Wim,

On 7/30/2012 1:56 PM, Wim Jongman wrote:
I have looked at the wiki and the previous discussion as pointed out by Scott and have this question: What problem is solved with Gerrit?

Assumption: Code reviews are desired/desirable...at least under some circumstances (e.g. contributions from non-committers)

If you grant the above assumption, I would say that Gerrit provides support for automating doing such code reviews (like any tool IMHO, it doesn't 'solve' the problem but rather 'improves/simplifies/supports' such a process).

It's not my intention/expectation that all commits/pushes to ECF would require a Gerrit review.  But there are occasions when having code reviews...and having support for doing so...would be useful IMHO (at least there are occasions when I would like to request that others review my contributions).

Scott









Regards,

Wim

On Mon, Jul 30, 2012 at 7:44 PM, Scott Lewis <slewis@xxxxxxxxxxxxx> wrote:
Hi Markus,


On 7/29/2012 11:03 PM, Markus Alexander Kuppe wrote:
<stuff deleted>

+1 for Gerrit.

We would probably have to host our own instance or have the EF
webmasters integrate our Jenkins server with Gerrit for us (assuming we
want/need a review system <> build integration).

Hmmm.   I had been assuming that we would just follow the process for requesting Gerrit usage via the EF

http://wiki.eclipse.org/Gerrit#Enabling_Gerrit_for_your_Eclipse.org_Project

...but I see what you mean about integrating with our Jenkins server.

Markus do you have any thoughts on how would you like to handle interacting with the EF admins about what's the best/right course here (e.g. hosting our own Gerrit vs. using EF Gerrit installation)?  I would like to see review system and build system integration (as Alex's video demonstrates)...but I'm not sure what this will take...and I certainly don't want to take on a whole lot of additional integration (and the inevitable maintenance)...if we don't have to.

Thanks,

Scott




_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev



_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev

_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev


_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev


_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev