Hi Wim,
So I'm going to summarize...please correct me if I'm inaccurate
First, the class in question is:
org.eclipse.ecf.internal.ui.actions.SelectProviderAction right?
You would like to be able to use it in presence ui plugin, and
possibly elsewhere, right?
>Is it not ok for ECF to use it's own internals?
As you know, the internal designation is at a bundle level, and
since ECF has several ui bundles...they don't get unfettered access
to each other's internal packages. It is possible to setup
'special relationships' between bundles (e.g. x-friends), to provide
such access...but I'm not sure whether this is the right choice for
this particular class.
I believe that Remy Suen was the author of
SelectProviderAction...and I see a note at the top of the class that
says
// TODO, we should rework this class... it's confusing >_<
...so perhaps that's why it was made internal originally...but I'm
not certain.
I guess what would be best is if we get Remy's input on this
class...whether he thinks it should be improved and made into API,
or changed and made into API, or left the same and used via
x-friends (which is less desirable in my view).
And just to be clear...as far as I'm concerned we can take any
strategy necessary here...although if we create new API we'll need a
minor release to distribute.
Thanks,
Scott
On 1/16/2012 12:30 AM, Wim Jongman wrote:
Dang!!!
No I did not look wrong.
Here it is again. I need to use an internal class (SelectProviderAction) from
o.e.e.ui in o.e.e.presence.ui. The compiler gives me errors
due to tightened restriction on usage of internals.
Regards,
Wim
On Mon, Jan 16, 2012 at 9:26 AM, Wim
Jongman <wim.jongman@xxxxxxxxx>
wrote:
Sorry I
looked wrong. The action is actually in presence.ui
(SelectProviderAction).
On Mon, Jan 16, 2012 at
12:04 AM, Wim Jongman <wim.jongman@xxxxxxxxx>
wrote:
Hi,
I am making a patch for the chats view which is
in presence.ui I need to reuse an action which
is in examples.ui
It is the open chat provider action. It is an
internal class and using it in presence.ui will
fail the compile due to strict compilation
settings in presence.ui
What I want to do is to provide a link in the
empty chats view to the open provider action.
Any ideas how to fix this without duplicating
the action's code?
Thanks
Wm
_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev
|
