[ecf-dev] About IRemoteCallParameter[] parsing

[Pavel Samolisov <samolisov@xxxxxxxxx>]

Hello Folks,

I write an RPC adapter for ECF and have a question.

RPC uses parameters array for request, but parameters map, and each
parameter may not have a name, i.e.
RemoteCallFactory.createRemoteCall(RpcConstants.TEST_ECHO_METHOD_NAME,
new Object[]{"Hello, world!"});

I mean user MUST NOT register  a callable with parameter names, i.e.
user can register a callable
RemoteCallableFactory.createCallable(RpcConstants.TEST_ECHO_METHOD_NAME), but
to use a call
RemoteCallFactory.createRemoteCall(RpcConstants.TEST_ECHO_METHOD_NAME,
new Object[]{"Hello, world!"});

This callable does not have any parameters but the call have this ones.

Our implementation of preparing parameters (see
AbstractClientContainer#prepareParameters) uses default callable
parameters and, if this parameters are not defined, do not serialize
real call parameters.
Some more, RemoteCallParameter constructor has
Assert.isNotNull(this.name) that checks a name of parameter for null.

My question: should me refactoring this stuff or user just must register
callable with parameters if he/she want use call with parameters?

Sorry for my English.

Thanks

-- 
Pavel Samolisov, 
Eclipse Communication Framework committer,
Senior Software Developer,
http://psamolisov.blogspot.com

Attachment: signature.asc
Description: OpenPGP digital signature