[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ecf-dev] Changing the timeout configuration in ECF IRC provider Implementation

Hi Scott and All,

I checked the class implementation of which you have mentioned. Originally I wanted to change the Connect timeoutÂÂ(org.eclipse.ecf.internal.provider.irc.container.IRCChannelContainer.CONNECT_TIMEOUT)Âbecause it deals with the timeout on creation of connection and it was the problem which I suffered when connecting to private channels. So I'm gonna change it first and deal with the other timeout later.

I'll provide a path for this.

On 6 October 2010 00:19, Harshana Eranga Martin <harshana05@xxxxxxxxx> wrote:
Hi Scott, All,

Thanks a lot for the quick reply. I have created the enhancement requestÂ327032Âfor this addition. I assigned it to myself and start working on this right away. Thanks a lot for the directions. Be back with it asap.

Thanks & Regards,
Harshana


On 6 October 2010 00:03, Scott Lewis <slewis@xxxxxxxxxxxxx> wrote:
ÂHi Harshana,


On 10/5/2010 10:23 AM, Harshana Eranga Martin wrote:
Hi All,

Can we do it? Is there any place to configure the timeout period in the current Implementation? If not I would like to do this asap :)

The current IRC provider implementation doesn't support setting the connection timeout. ÂHowever, it would/could easily be added. ÂThe way to do it would be to add some notion of timeout to the implementation of org.eclipse.ecf.internal.provider.irc.container.IRCRootContainer.connect(ID, IConnectContext).

The current implementation of this method creates an IRCConnection (from IRClib library), but does *not* call IRCConnection.setTimeout(timeout). ÂIt could easily be enhanced to do so...for example on approx line 170 call connection.setTimeout(timeout). ÂOf course if this is done then some means to specify the desired timeout (e.g. upon creation of the container, etc) should be added as well. ÂNote there is also a connect timeout...I'm not sure if you wish to customize that as well (see org.eclipse.ecf.internal.provider.irc.container.IRCChannelContainer.CONNECT_TIMEOUT).

In any case, please open an enhancement request for this...and if you would like to add this functionality yourself Harshana then please assign the new bug to yourself and go ahead and make the additions. ÂI won't be able to immediately work on it myself, unfortunately.

Scott



_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev




--
Harshana Eranga Martin
Department of Computer Science & Engineering,
University of Moratuwa,
Moratuwa,
Sri Lanka.

ECF Committer: http://www.eclipse.org/ecf/
Blog: http://harshana05.blogspot.com
Profile: https://www.google.com/profiles/harshana05



--
Thanks and Regards,
Harshana Martin
--
Harshana Eranga Martin
Department of Computer Science & Engineering,
University of Moratuwa,
Moratuwa,
Sri Lanka.

ECF Committer: http://www.eclipse.org/ecf/
Blog: http://harshana05.blogspot.com
Profile: https://www.google.com/profiles/harshana05