[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ecf-dev] renaming bundle

Hi Chris,

We have this already:  https://bugs.eclipse.org/bugs/show_bug.cgi?id=166507

Three of the deps for the jxta provider (servlet, logging, jetty) are already in Orbit, and our CQ's for reuse have been approved.  We do need to get the jxta code changed over and a build process in place for using the Orbit bundles for this, however.

Also, the jxta API code itself, once approved (it's been approved for our use as an incubator project, but not fully approved yet) should be made into bundles as well and put into Orbit project, but as always that's a prioritization/resource issue for ECF.  People willing/wanting and able to do it are welcome to, of course.  It has to be coordinated with Pierre's ongoing work on the JXTA provider obviously.

But please feel free to open bugs for the items listed above as desired so they can be tracked....I would appreciated it.

Scott

Chris Aniszczyk wrote:

We eventually need to open a bug to move these deps to Orbit if they don't exist there yet :)

Cheers,

---
Chris Aniszczyk | IBM Lotus | Eclipse Committer | http://mea-bloga.blogspot.com | +1 860 839 2465

Inactive hide details for Scott Lewis ---02/21/2007 01:00:30 PM---Hi Pierre,Scott Lewis ---02/21/2007 01:00:30 PM---Hi Pierre,


From:

Scott Lewis <slewis@xxxxxxxxxxxxx>

To:

"Eclipse Communication Framework (ECF) developer mailing list." <ecf-dev@xxxxxxxxxxx>

Date:

02/21/2007 01:00 PM

Subject:

Re: [ecf-dev] renaming bundle




Hi Pierre,

I think I understand what was wrong. In your manifest.mf in the org.eclipse.ecf.provider.jxta plugin you had this:

Bundle-ClassPath: lib/bcprov-jdk14.jar,
lib/javax.servlet.jar,
lib/org.mortbay.jetty.jar,
lib/log4j-1.2.13.jar,
src/org/

But your classes in this plugin were being compiled to <project>/bin, and the classpath also needed to include the jxta libs (and aren't listed above). So changing the above to this:

Bundle-ClassPath: lib/bcprov-jdk14.jar,
lib/javax.servlet.jar,
lib/org.mortbay.jetty.jar,
lib/log4j-1.2.13.jar,
lib/jxta.jar,
lib/jxtacms.jar,
lib/jxtacmsshell.jar,
./bin

Seems to get things going in terms of classloading. Notice the ./bin at the bottom. That does the trick for the classes defined in org.eclipse.ecf.provider.jxta.

Also, the build.properties has to be updated, and once I ran with the above changes there was a NPE in the JxtaSOContainer class because a line had been commented out, so I removed the comment.

See attached for a patch for these three files in provider.jxta: manifest.mf, build.properties, JxtaSOContainer.java.

You can apply it as appropriate. Please let everyone know via this list when ready...I (for one) want to play with it some more :).

Thanks,

Scott



Pierre Henry Perret wrote:
      Salutations to the ecf team,

      Changing the name of an ecf container class doesn't seem to be equivalent to just renaming the class. I have renamed the JXTASOContainer class to JxtaContainer class and when the ecf.jxta.jp2p container is launched, it tries to load a bundle...which leads to an error.

      Any help or suggestion would be appreciated on how to get this solved.

      p.s: to see the run, just launch the jxta.rcpexample bundle and see how the initialize method is run.

      --
      Pierre-Henry Perret
      Eclipse ECF committer




      _______________________________________________
      ecf-dev mailing list
      ecf-dev@xxxxxxxxxxx
      https://dev.eclipse.org/mailman/listinfo/ecf-dev
       
### Eclipse Workspace Patch 1.0
#P org.eclipse.ecf.provider.jxta
Index: build.properties
===================================================================
RCS file: /home/cvs/ecf/org.eclipse.ecf.provider.jxta/build.properties,v
retrieving revision 1.1
diff -u -r1.1 build.properties
--- build.properties 24 Jan 2007 22:09:31 -0000 1.1
+++ build.properties 21 Feb 2007 18:57:46 -0000
@@ -6,4 +6,7 @@
               log4j.properties,\
               plugin.xml,\
               src/
-bin.includes = src/org/
+bin.includes = src/org/,\
+               lib/jxta.jar,\
+               lib/jxtacms.jar,\
+               lib/jxtacmsshell.jar
Index: src/org/eclipse/ecf/provider/jxta/container/JXTASOContainer.java
===================================================================
RCS file: /home/cvs/ecf/org.eclipse.ecf.provider.jxta/src/org/eclipse/ecf/provider/jxta/container/JXTASOContainer.java,v
retrieving revision 1.3
diff -u -r1.3 JXTASOContainer.java
--- src/org/eclipse/ecf/provider/jxta/container/JXTASOContainer.java 15 Feb 2007 06:02:03 -0000 1.3
+++ src/org/eclipse/ecf/provider/jxta/container/JXTASOContainer.java 21 Feb 2007 18:57:46 -0000
@@ -104,7 +104,7 @@

public JXTASOContainer(  ) {

- //soMGR= new JXTASOManager( this, netPG );
+ soMGR= new JXTASOManager( this, netPG );

try {
localID= IDFactory.getDefault().createStringID( JXTA_CONTAINER );
Index: META-INF/MANIFEST.MF
===================================================================
RCS file: /home/cvs/ecf/org.eclipse.ecf.provider.jxta/META-INF/MANIFEST.MF,v
retrieving revision 1.5
diff -u -r1.5 MANIFEST.MF
--- META-INF/MANIFEST.MF 15 Feb 2007 06:06:14 -0000 1.5
+++ META-INF/MANIFEST.MF 21 Feb 2007 18:57:46 -0000
@@ -217,5 +217,8 @@
 lib/javax.servlet.jar,
 lib/org.mortbay.jetty.jar,
 lib/log4j-1.2.13.jar,
- src/org/
+ lib/jxta.jar,
+ lib/jxtacms.jar,
+ lib/jxtacmsshell.jar,
+ ./bin
Bundle-RequiredExecutionEnvironment: J2SE-1.5
_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev


_______________________________________________ ecf-dev mailing list ecf-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/ecf-dev

GIF image

GIF image