Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [e4-dev] Feedback about E4 Tools OrionEditor

Hi Wim, Paul

@Wim : Thank's for your info. I had worked with Paul on OrionEditorControl which is a SWT Control which wraps a SWT Browser which loads JS Orion. Léo works on the OrionEditor which is a 3x EditorPart which uses OrionEditorControl.


At first why OrionEditor is not based on E4 part?

E4 by itself doesn't have the notion of editors. 

What about part with @Inject, MDirtyable, etc. I thought the goal of E4 is to provide new concept to replace 3.x EditorPart, ViewPart?
 
The target of this work is to provide CSS/HTML/_javascript_ editing in the Eclipse SDK (3.x based) using the Orion editor (we'll probably update to Orion 5.0 soon).

In the Eclipse SDK, cool! 


This is the first pass work done by UCOSP student Léo Denault

From actually loading the content point of view, a longer term goal is to use the FileBuffers and TextFileBuffer API so that it can support some of the common text editor behaviour people expect (like changes in one editor show up if the same file is opened on the other editor).  FileBuffers will also tie into how Eclipse manages encoding, line separators, loading and saving, etc.

IMHO I think editor should work on RCP, RAP, IDE context. I think it's shame for instance that 3.x TextEditor cannot be used with RCP because it works only with IFile.

It's perhaps out of scope, but an important thing in an editor is the Search dialog (Ctrl+F). By using Orion you will not have this feature because you don't extend texteditor. In my case I have redevelopped this dialog and it works on the 3 contexts. It should be cool if E4 provides a Search Dialog service like (or other) which manages Search Dialog which works for 3.x texteditor but for other editor like OrionEditorControl.

Regards Angelo


PW


--
Paul Webster
Hi floor.  Make me a sammich! - GIR

_______________________________________________
e4-dev mailing list
e4-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/e4-dev



Back to the top