| Re: [e4-dev] MCompositePart has been added to the UI Model |
I attached the updated patch to https://bugs.eclipse.org/bugs/show_bug.cgi?id=396528. Szymon From: Eric Moffatt <emoffatt@xxxxxxxxxx> To: E4 Project developer mailing list <e4-dev@xxxxxxxxxxx> Date: 2013-08-01 19:05 Subject: Re: [e4-dev] MCompositePart has been added to the UI Model Sent by: e4-dev-bounces@xxxxxxxxxxx Szymon, Thanks for both the code and the generous offer. One of the reasons I added the model element this early was to give us all the maximum amout of time to get the 'outer' base class correct. As a start is there any chance you'd like to update your patch to use the new model element ? I can then use that along with Tom Schindl's split editor demo to produce a 'production' (perhaps more than one based on how it's going to be used) base class for folks wanting to use MCompositeParts... Keep on trucking, Eric (Embedded image moved to file: pic28504.gif)Inactive hide details for Szymon Ptaszkiewicz ---07/30/2013 07:57:23 AM---Hi Eric, Thanks for the info! I already added similarSzymon Ptaszkiewicz ---07/30/2013 07:57:23 AM---Hi Eric, Thanks for the info! I already added similar model stuff when I started (Embedded image (Embedded image moved to file: pic25728.gif) moved to file: Szymon Ptaszkiewicz <szymon.ptaszkiewicz@xxxxxxxxxx> pic31224.gif) From: (Embedded image (Embedded image moved to file: pic41661.gif) moved to file: E4 Project developer mailing list <e4-dev@xxxxxxxxxxx>, pic57305.gif) To: (Embedded image (Embedded image moved to file: pic62212.gif) moved to file: 07/30/2013 07:57 AM pic57084.gif) Date: (Embedded image (Embedded image moved to file: pic52979.gif) moved to file: Re: [e4-dev] MCompositePart has been added to the UI pic53140.gif) Model Subject: (Embedded image (Embedded image moved to file: pic15636.gif) moved to file: e4-dev-bounces@xxxxxxxxxxx pic50009.gif) Sent by: Hi Eric, Thanks for the info! I already added similar model stuff when I started working on https://bugs.eclipse.org/bugs/show_bug.cgi?id=396528 some time ago. The patch attached to that bug provides also initial implementation how to initialize multi-editors using MCompoundPart (according to your commit it would be MCompositePart). I don't have answers to your questions yet, but I'm open to take my share of workload to help implementing this :-) Szymon From: Eric Moffatt <emoffatt@xxxxxxxxxx> To: e4-dev@xxxxxxxxxxx Date: 2013-07-29 20:24 Subject: [e4-dev] MCompositePart has been added to the UI Model Sent by: e4-dev-bounces@xxxxxxxxxxx I've just done the first commit against https://bugs.eclipse.org/bugs/show_bug.cgi?id=378298. This adds a new element MCompositePart into the UI Model. It's a combination of both an MPart and an MPartSashContainer; allowing a part to contain a substructure. This is just the first (and easiest) part of the development; the real work is going to be how we map the new capability onto our existing presentation. What does 'getActivePart()' mean now ? Possibilities include (at least): - The 'outermost' active part (i.e. the first one encountered walking *down* from the window / perspective - The 'innermost' one (i.e. the currently active leaf within the substructure) - Perhaps a new API 'getActivePartChain' that returns an ordered list of the 'active' parts ? How does the Commands infrastructure interact with the collection of parts; if the various parts on the active chain define different (possibly conflicting?) key bindings how are they and their handlers resolved ? If I have a CompositePart in a stack should the stack show the toolbar and dropdown menu from the active leaf ? This is for the case where the substructure consists of two (or more) parts in a sash structure where the parts are *not* in a stack. What other issues might come up ? I've intentionally put the model element in place early so we'll have the maximum amount of time to figure these things out before Luna ships... Onwards, Eric _______________________________________________ e4-dev mailing list e4-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/e4-dev _______________________________________________ e4-dev mailing list e4-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/e4-dev _______________________________________________ e4-dev mailing list e4-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/e4-dev
Attachment:
pic28504.gif
Description: GIF image
Attachment:
pic31224.gif
Description: GIF image
Attachment:
pic25728.gif
Description: GIF image
Attachment:
pic57305.gif
Description: GIF image
Attachment:
pic41661.gif
Description: GIF image
Attachment:
pic57084.gif
Description: GIF image
Attachment:
pic62212.gif
Description: GIF image
Attachment:
pic53140.gif
Description: GIF image
Attachment:
pic52979.gif
Description: GIF image
Attachment:
pic50009.gif
Description: GIF image
Attachment:
pic15636.gif
Description: GIF image
