Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [e4-dev] A breaking model change


Tom, we should also mention the impending change to the IPresentationEngine API: (Bug 318619)

At the moment there are two 'createGui' calls. There's one with one argument (the MUIElement) that figures out the correct parent 'widget' and calls the second one. The change is to add a third parameter to the second one, allowing the specification of the 'parent context' as well.

This will allow a 'createGui' to fully define the information necessary to render the widget. Without this change we could never (for example) call 'createGui' on an MToolControl that has not been added to the model's structure.

The new API for the second 'createGui' would be

createGui(MUIElement element, Object parentWidget, IEclipseContext parentContext);

If you have renderer implemenations then they must be updated to use the new API.

OK, given this change I now promise not to break the model anymore as well...;-).

Eric


From: Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx>
To: E4 Project developer mailing list <e4-dev@xxxxxxxxxxx>
Date: 07/05/2010 12:40 PM
Subject: Re: [e4-dev] A breaking model change
Sent by: e4-dev-bounces@xxxxxxxxxxx





Hi,

todays I-Build will hold the change to parentID => parentId. I case
you've already used the MenuContribution-story you need to update your
.e4xmi and/or ModelProcessor.

Tom

Am 05.07.10 18:16, schrieb Tom Schindl:
> Hi,
>
> I know we promised to NOT break the model anymore but there is one small
> inconsitency in MenuContribution#parentID.
>
> The description of the change is found in
>
https://bugs.eclipse.org/bugs/show_bug.cgi?id=318393.
>
> If you read the bug you'll see that there are other none camel case
> attributes which hold the term URI but they at least follow the
> JDK-style of nameing.
>
> We believe it is better to fix this at this late point in time. The
> customers for MenuContribution are not too many (probably only the SDK
> itself).
>
> Tom
>


--
B e s t S o l u t i o n . a t                        EDV Systemhaus GmbH
------------------------------------------------------------------------
tom schindl                                        geschaeftsfuehrer/CEO
------------------------------------------------------------------------
eduard-bodem-gasse 5/1    A-6020 innsbruck      phone    ++43 512 935834
_______________________________________________
e4-dev mailing list
e4-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/e4-dev



Back to the top