It should even be possible (and more readable) to use names instead of an index. Also the names don't need to be unique within the ResourceSet but only for those elements which are referable from a certain EReference.
That is for instance when a Handler refers to a Command there's no point in adding the type information, as long as the names (ids) are unique between all commands.
Best Regards, Sven
On Mar 11, 2010, at 2:21 PM, Boris Bokowski wrote: Also I don't think the IDs have to be globally unique, they just have to be unique within the resource. Which means we could also have: Command-1 Command-2 Handler-1 Handler-2 Handler-3 Remy, please correct me if I'm wrong. Boris <graycol.gif>Remy Suen---03/11/2010 07:55:17 AM---On Thu, Mar 11, 2010 at 6:01 AM, Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx> wrote: <ecblank.gif> From: | <ecblank.gif> Remy Suen/Ottawa/IBM@IBMCA | <ecblank.gif> To: | <ecblank.gif> E4 Project developer mailing list <e4-dev@xxxxxxxxxxx> | <ecblank.gif> Date: | <ecblank.gif> 03/11/2010 07:55 AM | <ecblank.gif> Subject: | <ecblank.gif> Re: [e4-dev] Unique Id generation Proposal | <ecblank.gif> Sent by: | <ecblank.gif> e4-dev-bounces@xxxxxxxxxxx | On Thu, Mar 11, 2010 at 6:01 AM, Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx> wrote: > The currently generated Id are IMHO not 100% ideal. My proposal would be to > use $EClassname-$UUID. I also prefer Java-UUID but that probably just me. I don't really care how the string looks or is generated as long as someone can guarantee to me that they are unique. If you want to look at the code, it's just in org.eclipse.e4.workbench.ui.internal.E4XMIResource. Regards, Remy ---------- Remy Suen Eclipse Platform/UI Committer IBM Ottawa 613-356-5162_______________________________________________ e4-dev mailing list e4-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/e4-dev _______________________________________________ e4-dev mailing list e4-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/e4-dev
|