Re: [e4-dev] M3 on Friday, polish and fixing tomorrow

[Lars Vogel <lars.vogel@xxxxxxxxxxxxxx>]

Hi,

after editing the Application.xmi via the EMF editor I receive an NPE.

Seems like the EMF Editor leaves the model elements in if you delete
the content. For example I set the iconURI and then removed it again.
Now I receive a NPE at
org.eclipse.e4.workbench.ui.renderers.swt.WBWRenderer.createWidget(WBWRenderer.java:277)

Would it make sence to check the length of the URI or is their a more
generic way of solving this?

----------------
if (uri != null) { // perhaps better (url!=null && url.lenght()>0)?
			try {
				Image image = ImageDescriptor.createFromURL(new URL(uri))
						.createImage();
				wbwShell.setImage(image);
			} catch (MalformedURLException e) {
				// invalid image in model, so don't set an image
				if (logger != null)
					logger.error(e);
			}
		}

Let me know if you want to have a bug report for this.

Best regards, Lars

2010/1/14 Dan Rubel <dan_rubel@xxxxxxxxxxxxxxxxxx>:
> Remy Chi Jian Suen wrote:
>
> Hi Dan,
>
> On Wed, Jan 13, 2010 at 5:06 PM, Dan Rubel <dan_rubel@xxxxxxxxxxxxxxxxxx>
> wrote:
>
>
> 1) e4 Install
>
> There does not seem to be an "all in one" e4 download as mentioned on the e4
> install page ( http://wiki.eclipse.org/E4/Install ). To get things running,
> I followed the "You can also install pieces of e4 individually..."
> installation instructions and loaded everything specified there. I'm happy
> to update the install instructions if so desired.
>
>
> The e4 SDK download should have everything (albeit not named "all in
> one"). If there is some piece that is missing (not including example
> projects), please open a bug.
>
>
> My mistake... please ignore.
>
> 2) Photo demo
>
> I loaded the photo demo tagged "I20100112-0800" and it loaded as expected. I
> updated step #7 in the instructions slightly to be more clear. Will the
> photo example (and others) be tagged with "M3" or something like that to
> make it easier to find for those using a milestone?
>
>
> I believe that's on the plan but I don't think anyone on the UI team
> is on it at the moment. I suggest harassing on the bug (if there is
> one) and bringing it up on the meeting tomorrow.
>
>
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=298011
>
> The photo demo opens as expected. I created an album and downloaded the
> picture from bug 263898 as specified in the instructions, and the picture
> appears in the application. Selecting the picture displays the picture and
> its thumbnail, but the "Location" view is empty.
>
>
> Please open a bug about this.
>
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=299649
>
>
> _______________________________________________
> e4-dev mailing list
> e4-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/e4-dev
>
>



-- 
Lars
http://www.vogella.de - Tutorials about Java, Eclipse and Web programming
http://www.twitter.com/vogella - Lars on Twitter