Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [e4-dev] PartService: Strings or MParts? Collections or arrays?

On Wed, Nov 18, 2009 at 7:53 AM, Remy Suen <remysuen@xxxxxxxxxx> wrote:
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=295003

Follow up discussion about showPart(*) to the bug, please.


> Since the functionality that (E)PartService will expose will be quite
> similar to 3.x's IWorkbenchPage, I figured I'd take a look at that interface
> and see what methods we might want in the e4 world. I noticed it has
> getViewReferences() which seem pretty handy but then I noticed that it
> returns an IViewReference[]. In e4, would we want to return a
> Collection<MPart> (or List<MPart>) or an MPart[]?

I would stick with Collection<whatever> and List<whatever> if
possible.  We shouldn't be returning arrays in the general cases
(although it might make sense in a few cases).

PW

-- 
Paul Webster
Hi floor.  Make me a sammich! - GIR


Back to the top