[dtp-pmc] Request PMC approval to deliver fix for bug 254663 in DTP 1.6.

[Brian Payton <bpayton@xxxxxxxxxx>]

Hi PMC,

I'd like to get the following fix into
DTP 1.6.2 M1:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=254663

The bug abstract is "Query parser
hangs when it encounters undefined characters".

This is a low-risk fix to the SQL Query
parser that solves a serious problem.  See attached notes for more
information.

Regards,
Brian

Brian Payton
SQL and XML Query Tools Development
IBM Silicon Valley Laboratory
(408) 463-2989, T/L 8-543-2989


----- Forwarded by Brian
Payton/Santa Teresa/IBM on 11/07/2008 02:47 PM -----

brian.fitzpatrick@xxxxxxxxxx

11/07/2008 06:11 AM

To	Brian Payton/Santa Teresa/IBM@IBMUS
cc	LChan@xxxxxxxxxxx, Sheila Sholars/Santa Teresa/IBM@IBMUS, jgraham@xxxxxxxxxx
Subject	Re: Query parser hang problem

We're in a test/fix pass, so you bet. This sounds like a critical fix.
When you find a fix, please send an e-mail to the dtp-pmc list to ask for
approval and point out the critical nature of the bug, what's going on,
impact of the fix, etc. We would then have to request a new build from
Xiaoying on her Monday (Sunday afternoon) so we could test again. Sounds
like a pretty limited impact so I'd hope we could test the rest of the
build without the fix and then just test this one tweaked spot in the new
build. 

Wouldn't be much of a test/fix pass if we couldn't get fixes in. :)

--Fitz 

Brian Fitzpatrick
Eclipse Data Tools Platform PMC Chair
Eclipse Data Tools Platform Connectivity Team Lead
Staff Software Engineer, Sybase, Inc.

Brian Payton <bpayton@xxxxxxxxxx>

11/07/2008 02:14 AM

To	brian.fitzpatrick@xxxxxxxxxx
cc	LChan@xxxxxxxxxxx, Sheila Sholars <sholars@xxxxxxxxxx>
Subject	Query parser hang problem

Hi Brian, 

At the last minute one of the teams here reported a "hang" problem
in the Query parser.  It occurs when the parser input contains the
character "{" or "}" (left or right brace), like this:

   select aa{bb from table1 

SQL doesn't use braces in its syntax, so that statement is syntactically
invalid, but the parser certainly shouldn't hang.  This apparently
is caused by a bug in the version of LPG (v1.1) that we use in DTP.  It's
been fixed in v2, but unfortunately we can't use v2 in DTP, since it's
not in Orbit. 

I've been trying my darndest to fix this problem in our DB2 extension to
the DTP query parser rather than in the DTP query parser itself, but haven't
been able to so far. I'll keep trying, but if I can't make it happen, is
there any chance of getting a fix into M1? 

Regards,
Brian

Brian Payton
SQL and XML Query Tools Development
IBM Silicon Valley Laboratory
(408) 463-2989, T/L 8-543-2989