Re: [dtp-dev] Where can I get the unit tests for o.e.d.modelbase?

[Chris Hines <eclipse-bugzilla@xxxxxxxxxx>]

Ok, the bug id is 376359.

Chris Hines

On Mon, Apr 9, 2012 at 4:13 PM, Brian Payton <bpayton@xxxxxxxxxx> wrote:

Hi Chris,

You are correct, the COLA column should not be qualified with QUERY1.

Go ahead and open a DTP Bugzilla bug.

Thanks for reporting this problem.

Regards,
Brian

Brian Payton
DTP PMC Lead
Data Tools Development
IBM Silicon Valley Laboratory





From:        Chris Hines <eclipse-bugzilla@xxxxxxxxxx>

To:        DTP development mailing list <dtp-dev@xxxxxxxxxxx>
Date:        04/09/2012 01:06 PM
Subject:        Re: [dtp-dev] Where can I get the unit tests for o.e.d.modelbase?

Sent by:        dtp-dev-bounces@xxxxxxxxxxx

---

Thanks Brian,

Thanks, I have found the parser test plugin that you mentioned and I believe I have confirmed one of the bugs I have encountered by adding a test to that test suite and verifying that the test fails. I am happy to create a bugzilla entry for the bug. Should I just file the bug, or does a member of the dev team want to confirm it first?

The minimal query that reproduces the bug is:

    select * from (select colA from t1, t2) query1;

Running this query through the test method parserVerifySuccess() fails with this message:

junit.framework.AssertionFailedError: generated SQL does not match template SQL:
generated: SELECT * FROM (SELECT QUERY1.COLA FROM T1, T2) QUERY1
template:  SELECT * FROM (SELECT COLA FROM T1, T2) QUERY1

Not only does the generated SQL not match, but it is broken.

Thanks,
Chris Hines

On Mon, Apr 9, 2012 at 2:17 PM, Brian Payton <bpayton@xxxxxxxxxx> wrote:
Hi Chris,

The DTP modelbase plugins don't have any test code in the modelbase plugins directly.  (One reason is that 95% of the modelbase code is generated by EMF from model diagrams.  See the "model" folders in each plugin.)

However the modelbase "query" plugins are exercised pretty well by the SQL parser test plugin, org.eclipse.datatools.sqltools.parsers.sql.query.test.

Regards,
Brian

Brian Payton
DTP PMC Lead
Data Tools Development
IBM Silicon Valley Laboratory





From:        Chris Hines <eclipse-bugzilla@xxxxxxxxxx>
To:        dtp-dev@xxxxxxxxxxx
Date:        04/06/2012 10:53 AM
Subject:        [dtp-dev] Where can I get the unit tests for o.e.d.modelbase?
Sent by:        dtp-dev-bounces@xxxxxxxxxxx

---

Hello DTP developers,

I think I have found a couple of bugs in DTP modelbase but I want to confirm them before I submit reports to bugzilla. To that end I am looking for the existing test code for o.e.d.modelbase so I can write some new tests within the existing framework.

I have already cloned the GIT repository for o.e.d.modelbase, but I didn't see any tests.

If there is no existing test suite, then I will proceed without it, but I feel like I'm just missing something.

Chris Hines_______________________________________________
dtp-dev mailing list
dtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dtp-dev


_______________________________________________
dtp-dev mailing list
dtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dtp-dev

_______________________________________________
dtp-dev mailing list
dtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dtp-dev

_______________________________________________
dtp-dev mailing list
dtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dtp-dev